Issue 7799045: code review 7799045: cmd/go: allow ~ in middle of path, just not at beginning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7799045: code review 7799045: cmd/go: allow ~ in middle of path, just not at beginning (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

cmd/go: allow ~ in middle of path, just not at beginning An earlier CL disallowed ~ anywhere in GOPATH, to avoid problems with GOPATH='~/home' instead of GOPATH=~/home. But ~ is only special in the shell at the beginning of each of the paths in the list, and some paths do have ~ in the middle. So relax the requirement slightly. Fixes issue 4140.

Patch Set 1 #

Patch Set 2 : diff -r cc6264adc22b https://code.google.com/p/go/ #

Patch Set 3 : diff -r cc6264adc22b https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 62c96dd0ddc3 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/cmd/go/main.go	View	1 2 3	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-03-14 03:23:16 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/7799045/diff/4001/src/cmd/go/main.go File src/cmd/go/main.go (right): https://codereview.appspot.com/7799045/diff/4001/src/cmd/go/main.go#newcode137 src/cmd/go/main.go:137: fmt.Fprintf(os.Stderr, "go: GOPATH entry cannot contain shell metacharacter ...

12 years, 2 months ago (2013-03-14 03:29:39 UTC) #2

rsc

12 years, 2 months ago (2013-03-14 03:32:16 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=90c75b8f9526 ***

cmd/go: allow ~ in middle of path, just not at beginning

An earlier CL disallowed ~ anywhere in GOPATH, to avoid
problems with GOPATH='~/home' instead of GOPATH=~/home.
But ~ is only special in the shell at the beginning of each of
the paths in the list, and some paths do have ~ in the middle.
So relax the requirement slightly.

Fixes issue 4140.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/7799045

Expand All Messages | Collapse All Messages