Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(335)

Issue 7794043: code review 7794043: cmd/go: add go1.1 build tag, add -installsuffix flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by rsc
Modified:
7 years, 8 months ago
Reviewers:
CC:
golang-dev, bradfitz, r
Visibility:
Public.

Description

cmd/go: add go1.1 build tag, add -installsuffix flag The new build tag "go1.1" will be satisfied by any Go 1.z release >= 1.1. In general, the build tag "go1.x" will be satisfied by any Go 1.z release >= 1.x. What happens when we reach Go 2 is yet to be decided. The tags "go1" or "go1.0" are missing, because +build tags did not exist before then, and also because the Go 1.0 releases do not recognize them. The new -installsuffix flag gives access to the build context's InstallSuffix (formerly named InstallTag, but not part of Go 1.0), for use in isolating builds to custom directories. For example -race implies -installsuffix race, and an AppEngine-specific build might use -tags appengine -installsuffix appengine. Fixes issue 4116. Fixes issue 4443.

Patch Set 1 #

Patch Set 2 : diff -r 088249126434 https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 3 : diff -r 61fb96e61d11 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 61fb96e61d11 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r fd9e10489786 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -40 lines) Patch
M src/cmd/dist/build.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/go/build.go View 1 2 3 5 chunks +25 lines, -12 lines 0 comments Download
M src/cmd/go/doc.go View 1 2 3 3 chunks +16 lines, -10 lines 0 comments Download
A src/cmd/go/go11.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/cmd/go/main.go View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/pkg/go/build/build.go View 1 6 chunks +49 lines, -17 lines 0 comments Download

Messages

Total messages: 8
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 8 months ago (2013-03-13 19:22:40 UTC) #1
bradfitz
LGTM
7 years, 8 months ago (2013-03-13 19:27:06 UTC) #2
r
https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/build.go File src/cmd/go/build.go (right): https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/build.go#newcode70 src/cmd/go/build.go:70: name of compiler to use, as in runtime.Compiler (gccgo ...
7 years, 8 months ago (2013-03-13 20:02:15 UTC) #3
rsc
PTAL https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go File src/cmd/go/doc.go (left): https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go#oldcode65 src/cmd/go/doc.go:65: name is the base name of the containing ...
7 years, 8 months ago (2013-03-13 20:55:35 UTC) #4
r
LGTM i didn't know about mkdoc.sh
7 years, 8 months ago (2013-03-13 20:59:07 UTC) #5
r
Actually if not for the web, doc.go could just say Run go help documentation for ...
7 years, 8 months ago (2013-03-13 21:03:43 UTC) #6
rsc
On Wed, Mar 13, 2013 at 5:03 PM, Rob Pike <r@golang.org> wrote: > Actually if ...
7 years, 8 months ago (2013-03-13 21:07:37 UTC) #7
rsc
7 years, 8 months ago (2013-03-13 21:37:53 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=cc6264adc22b ***

cmd/go: add go1.1 build tag, add -installsuffix flag

The new build tag "go1.1" will be satisfied by any Go 1.z release >= 1.1.
In general, the build tag "go1.x" will be satisfied by any Go 1.z release >=
1.x.
What happens when we reach Go 2 is yet to be decided.

The tags "go1" or "go1.0" are missing, because +build tags did not exist
before then, and also because the Go 1.0 releases do not recognize them.

The new -installsuffix flag gives access to the build context's InstallSuffix
(formerly named InstallTag, but not part of Go 1.0), for use in isolating
builds to custom directories. For example -race implies -installsuffix race,
and an AppEngine-specific build might use -tags appengine -installsuffix
appengine.

Fixes issue 4116.
Fixes issue 4443.

R=golang-dev, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/7794043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b