code review 7794043: cmd/go: add go1.1 build tag, add -installsuffix flag

cmd/go: add go1.1 build tag, add -installsuffix flag

The new build tag "go1.1" will be satisfied by any Go 1.z release >= 1.1.
In general, the build tag "go1.x" will be satisfied by any Go 1.z release >= 1.x.
What happens when we reach Go 2 is yet to be decided.

The tags "go1" or "go1.0" are missing, because +build tags did not exist
before then, and also because the Go 1.0 releases do not recognize them.

The new -installsuffix flag gives access to the build context's InstallSuffix
(formerly named InstallTag, but not part of Go 1.0), for use in isolating
builds to custom directories. For example -race implies -installsuffix race,
and an AppEngine-specific build might use -tags appengine -installsuffix appengine.

Fixes issue 4116.
Fixes issue 4443.

[rsc, 2013-03-13 19:22:40]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-03-13 19:27:06]

LGTM

[r, 2013-03-13 20:02:15]

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/build.go
File src/cmd/go/build.go (right):

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/build.go#newcode70
src/cmd/go/build.go:70: name of compiler to use, as in runtime.Compiler (gccgo
or gc)
s/$/./ on these lines for consistency.

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go
File src/cmd/go/doc.go (left):

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go#oldcode65
src/cmd/go/doc.go:65: name is the base name of the containing directory.
revert this change.

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go#oldcode74
src/cmd/go/doc.go:74: specify output file name; see description above.
revert this deletion

[rsc, 2013-03-13 20:55:35]

PTAL

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go
File src/cmd/go/doc.go (left):

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go#oldcode65
src/cmd/go/doc.go:65: name is the base name of the containing directory.
Sorry, fixed. (The edit should have been made in build.go. This file is
mechanically generated. I added a header above.)

https://codereview.appspot.com/7794043/diff/2001/src/cmd/go/doc.go#oldcode74
src/cmd/go/doc.go:74: specify output file name; see description above.
On 2013/03/13 20:02:15, r wrote:
> revert this deletion

This deletion is actually correct, although I didn't intend it. The synopsis
above says
    go build [-o output] [build flags]
and this block is introduced by
    The build flags are shared by the build, install, run, and test commands:

-o is not one of these flags.

[r, 2013-03-13 20:59:07]

LGTM
i didn't know about mkdoc.sh

[r, 2013-03-13 21:03:43]

Actually if not for the web, doc.go could just say

Run
  go help documentation
for documentation about the go command.

and push all the complexity somewhere else.

[rsc, 2013-03-13 21:07:37]

On Wed, Mar 13, 2013 at 5:03 PM, Rob Pike <r@golang.org> wrote:

> Actually if not for the web, doc.go could just say
>
> Run
>   go help documentation
> for documentation about the go command.
>
> and push all the complexity somewhere else.
>

Yep. It's only there for the web.

[rsc, 2013-03-13 21:37:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=cc6264adc22b ***

cmd/go: add go1.1 build tag, add -installsuffix flag

The new build tag "go1.1" will be satisfied by any Go 1.z release >= 1.1.
In general, the build tag "go1.x" will be satisfied by any Go 1.z release >=
1.x.
What happens when we reach Go 2 is yet to be decided.

The tags "go1" or "go1.0" are missing, because +build tags did not exist
before then, and also because the Go 1.0 releases do not recognize them.

The new -installsuffix flag gives access to the build context's InstallSuffix
(formerly named InstallTag, but not part of Go 1.0), for use in isolating
builds to custom directories. For example -race implies -installsuffix race,
and an AppEngine-specific build might use -tags appengine -installsuffix
appengine.

Fixes issue 4116.
Fixes issue 4443.

R=golang-dev, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/7794043