Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(395)

Issue 77930043: Container Manager Interface

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by waigani
Modified:
7 years, 8 months ago
Reviewers:
mp+211825, thumper
Visibility:
Public.

Description

Container Manager Interface Change StartContainer to CreateContainer Change StopContainer to DestroyContainer https://code.launchpad.net/~waigani/juju-core/container-manager-interface/+merge/211825 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -67 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M container/interface.go View 1 chunk +4 lines, -4 lines 0 comments Download
M container/kvm/kvm.go View 2 chunks +2 lines, -2 lines 0 comments Download
M container/kvm/kvm_test.go View 1 chunk +5 lines, -5 lines 0 comments Download
M container/kvm/live_test.go View 4 chunks +8 lines, -8 lines 0 comments Download
M container/lxc/lxc.go View 2 chunks +2 lines, -2 lines 0 comments Download
M container/lxc/lxc_test.go View 11 chunks +37 lines, -37 lines 0 comments Download
M container/testing/common.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/local/environ.go View 3 chunks +3 lines, -3 lines 0 comments Download
M worker/provisioner/kvm-broker.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/provisioner/lxc-broker.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
waigani
Please take a look.
7 years, 8 months ago (2014-03-19 21:13:25 UTC) #1
thumper
7 years, 8 months ago (2014-03-19 21:23:55 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b