code review 77900043: strings, bytes: ReadAt should not mutate receiver

strings, bytes: ReadAt should not mutate receiver

CL 77580046 caused a data race issue with tests that assumes ReadAt
does not mutate receiver. This patch partially revert CL 77580046
to fix it.

[ruiu, 2014-03-19 18:58:54]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-03-19 19:01:51]

https://codereview.appspot.com/77900043/diff/60001/src/pkg/bytes/reader.go
File src/pkg/bytes/reader.go (right):

https://codereview.appspot.com/77900043/diff/60001/src/pkg/bytes/reader.go#ne...
src/pkg/bytes/reader.go:94: // the buffer that affect the seek offset was not a
ReadRune,
affects

But let's remove the documentation changes from this CL and get the build fixed,
and then you can wordsmith with Rob in a later CL.

[ruiu, 2014-03-19 19:03:57]

Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[ruiu, 2014-03-19 19:06:19]

I verified "go test -race archive/zip" now passed locally.


On Wed, Mar 19, 2014 at 12:03 PM, <ruiu@google.com> wrote:

> Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc:
> golang-codereviews@googlegroups.com),
>
> Please take another look.
>
>
> https://codereview.appspot.com/77900043/
>

[bradfitz, 2014-03-19 19:12:42]

LGTM

Thanks

[bradfitz, 2014-03-19 19:13:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=fcfdb8a7aa64 ***

strings, bytes: ReadAt should not mutate receiver

CL 77580046 caused a data race issue with tests that assumes ReadAt
does not mutate receiver. This patch partially revert CL 77580046
to fix it.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/77900043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[gobot, 2014-03-19 19:26:52]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/c3b65be158bdf0691b025d9552a8e6a71d49d5c1

[ruiu, 2014-03-19 19:36:46]

TestOverflowSleep in time/sleep_test.go seems too freaky on NetBSD. It has
already raised false alarms for my commits (I believe) two times. Can we
fix it or disable it on NetBSD?


On Wed, Mar 19, 2014 at 12:26 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/c3b65be158bdf0691b025d9552a8e6a71d49d5c1
>
> https://codereview.appspot.com/77900043/
>

[bradfitz, 2014-03-19 20:02:44]

Disabling it hides the problem

Fixing it is what these three months are for.
 On Mar 19, 2014 12:36 PM, "Rui Ueyama" <ruiu@google.com> wrote:

> TestOverflowSleep in time/sleep_test.go seems too freaky on NetBSD. It has
> already raised false alarms for my commits (I believe) two times. Can we
> fix it or disable it on NetBSD?
>
>
> On Wed, Mar 19, 2014 at 12:26 PM, <gobot@golang.org> wrote:
>
>> This CL appears to have broken the netbsd-amd64-bsiegert builder.
>> See http://build.golang.org/log/c3b65be158bdf0691b025d9552a8e6a71d49d5c1
>>
>> https://codereview.appspot.com/77900043/
>>
>
>