code review 7789048: bytes,string: move the BUG to the comment of the functi...

bytes,string: move the BUG to the comment of the function it's about
Avoids printing it every time we ask a question about the package from
the command line.

[r, 2013-03-16 00:05:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-03-16 00:05:42]

LGTM

On Fri, Mar 15, 2013 at 5:05 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> bytes,string: move the BUG to the comment of the function it's about
> Avoids printing it every time we ask a question about the package from
> the command line.
>
> Please review this at
https://codereview.appspot.**com/7789048/<https://codereview.appspot.com/7789...
>
> Affected files:
>   M src/pkg/bytes/bytes.go
>   M src/pkg/strings/strings.go
>
>
> Index: src/pkg/bytes/bytes.go
> ==============================**==============================**=======
> --- a/src/pkg/bytes/bytes.go
> +++ b/src/pkg/bytes/bytes.go
> @@ -461,10 +461,10 @@
>         return unicode.IsSpace(r)
>  }
>
> -// BUG(r): The rule Title uses for word boundaries does not handle
> Unicode punctuation properly.
> -
>  // Title returns a copy of s with all Unicode letters that begin words
>  // mapped to their title case.
> +//
> +// BUG(r): The rule Title uses for word boundaries does not handle
> Unicode punctuation properly.
>  func Title(s []byte) []byte {
>         // Use a closure here to remember state.
>         // Hackish but effective. Depends on Map scanning in order and
> calling
> Index: src/pkg/strings/strings.go
> ==============================**==============================**=======
> --- a/src/pkg/strings/strings.go
> +++ b/src/pkg/strings/strings.go
> @@ -492,10 +492,10 @@
>         return unicode.IsSpace(r)
>  }
>
> -// BUG(r): The rule Title uses for word boundaries does not handle
> Unicode punctuation properly.
> -
>  // Title returns a copy of the string s with all Unicode letters that
> begin words
>  // mapped to their title case.
> +//
> +// BUG(r): The rule Title uses for word boundaries does not handle
> Unicode punctuation properly.
>  func Title(s string) string {
>         // Use a closure here to remember state.
>         // Hackish but effective. Depends on Map scanning in order and
> calling
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-03-16 00:08:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=b5b5c246be0c ***

bytes,string: move the BUG to the comment of the function it's about
Avoids printing it every time we ask a question about the package from
the command line.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7789048

[rsc, 2013-03-19 18:40:15]

In this form the BUG(r): prefix should probably be dropped.