code review 7783046: database/sql: add missing []byte and RawBytes conversions

database/sql: add missing []byte and RawBytes conversions

E.g conversions from numeric types to RawBytes are missing, what makes RawBytes unusable in some cases.

[julienschmidt, 2013-03-22 16:13:30]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org,
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-03-22 16:17:36]

https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert.go
File src/pkg/database/sql/convert.go (right):

https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert...
src/pkg/database/sql/convert.go:102: case *RawBytes:
isn't RawBytes only a scan destination? I don't think you need this here in the
source switch.

[julienschmidt, 2013-03-22 16:25:59]

On 2013/03/22 16:17:36, bradfitz wrote:
>
https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert.go
> File src/pkg/database/sql/convert.go (right):
> 
>
https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert...
> src/pkg/database/sql/convert.go:102: case *RawBytes:
> isn't RawBytes only a scan destination? I don't think you need this here in
the
> source switch.

This is the dest switch. But RawBytes might be dispensable as a dest for a
string source (string -> *sql.RawBytes) since string is not a valid returned
driver.Value

[julienschmidt, 2013-03-22 16:39:20]

On 2013/03/22 16:25:59, julienschmidt wrote:
> On 2013/03/22 16:17:36, bradfitz wrote:
> >
>
https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert.go
> > File src/pkg/database/sql/convert.go (right):
> > 
> >
>
https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert...
> > src/pkg/database/sql/convert.go:102: case *RawBytes:
> > isn't RawBytes only a scan destination? I don't think you need this here in
> the
> > source switch.
> 
> This is the dest switch. But RawBytes might be dispensable as a dest for a
> string source (string -> *sql.RawBytes) since string is not a valid returned
> driver.Value

Is string as a source necessary at all?

[bradfitz, 2013-03-22 16:53:03]

Are you fixing a bug or adding a feature?
 On Mar 22, 2013 9:26 AM, <google@julienschmidt.com> wrote:

> On 2013/03/22 16:17:36, bradfitz wrote:
>
> https://codereview.appspot.**com/7783046/diff/5001/src/pkg/**
>
database/sql/convert.go<https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert.go>
>
>> File src/pkg/database/sql/convert.**go (right):
>>
>
>
> https://codereview.appspot.**com/7783046/diff/5001/src/pkg/**
>
database/sql/convert.go#**newcode102<https://codereview.appspot.com/7783046/diff/5001/src/pkg/database/sql/convert.go#newcode102>
>
>> src/pkg/database/sql/convert.**go:102: case *RawBytes:
>> isn't RawBytes only a scan destination? I don't think you need this
>>
> here in the
>
>> source switch.
>>
>
> This is the dest switch. But RawBytes might be dispensable as a dest for
> a string source (string -> *sql.RawBytes) since string is not a valid
> returned driver.Value
>
>
https://codereview.appspot.**com/7783046/<https://codereview.appspot.com/7783...
>

[julienschmidt, 2013-03-22 16:55:47]

On 2013/03/22 16:53:03, bradfitz wrote:
> Are you fixing a bug or adding a feature?

This is a bug fix. This should already have worked since the initial Go 1
release.

[bradfitz, 2013-03-22 19:14:05]

LGTM

[bradfitz, 2013-03-22 19:19:24]

*** Submitted as https://code.google.com/p/go/source/detail?r=1ec96e11707f ***

database/sql: add missing []byte and RawBytes conversions

E.g conversions from numeric types to RawBytes are missing, what makes RawBytes
unusable in some cases.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7783046

Committer: Brad Fitzpatrick <bradfitz@golang.org>