code review 7783044: cmd/ld: replace -hostobj with -linkmode

cmd/ld: replace -hostobj with -linkmode

Still disabled. Need to fix TLS.

[rsc, 2013-03-18 20:12:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2013-03-18 20:19:04]

could you please leave issue 4069 open and just update it and lower
its severity?
as host linking for windows and arm is still not supported.

[minux1, 2013-03-18 20:24:12]

https://codereview.appspot.com/7783044/diff/5001/src/cmd/8l/obj.c
File src/cmd/8l/obj.c (right):

https://codereview.appspot.com/7783044/diff/5001/src/cmd/8l/obj.c#newcode135
src/cmd/8l/obj.c:135: if(isobj)
??

and there are other occurrences of 'isobj' in cmd/8l.

[rsc, 2013-03-19 19:36:21]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-03-19 19:36:44]

Back to being disabled. I remembered that TLS does not work yet.

[bradfitz, 2013-03-19 19:38:07]

LGTM

On Tue, Mar 19, 2013 at 12:36 PM, <rsc@golang.org> wrote:

> Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/7783044/<https://codereview.appspot.com/7783...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-03-19 19:47:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=97cbf15abc2c ***

cmd/ld: replace -hostobj with -linkmode

Still disabled. Need to fix TLS.

R=golang-dev, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/7783044

[dave_cheney.net, 2013-03-19 20:05:46]

This has broken many of the builders. Pretty much every one that uses cgo. 



On 20/03/2013, at 6:47 AM, rsc@golang.org wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=97cbf15abc2c ***
> 
> cmd/ld: replace -hostobj with -linkmode
> 
> Still disabled. Need to fix TLS.
> 
> R=golang-dev, minux.ma, bradfitz
> CC=golang-dev
> https://codereview.appspot.com/7783044
> 
> 
> https://codereview.appspot.com/7783044/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[albert.strasheim, 2013-03-21 20:23:21]

On 2013/03/19 20:05:46, dfc wrote:
> This has broken many of the builders. Pretty much every one that uses cgo. 

Something is still not right with extern variables:

https://code.google.com/p/go/issues/detail?id=5099