Issue 77820043: state: modify SetAPIAddresses to SetAPIHostPorts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77820043: state: modify SetAPIAddresses to SetAPIHostPorts

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rog

Modified:
10 years, 1 month ago

Reviewers:
mp+211736, gz

Visibility:
Public.

Description

state: modify SetAPIAddresses to SetAPIHostPorts We want to keep all the available metadata in the state, so that clients can be more intelligent about connecting. We can keep the existing APIAddresses API call, but augment it with another call that returns all the metadata too. https://code.launchpad.net/~rogpeppe/juju-core/524-state-api-hostports/+merge/211736 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: modify SetAPIAddresses to SetAPIHostPorts #

Patch Set 3 : state: modify SetAPIAddresses to SetAPIHostPorts #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -104 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/address.go	View	4 chunks	+111 lines, -57 lines	0 comments	Download
M	state/initialize_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/open.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	state/state_test.go	View	4 chunks	+56 lines, -39 lines	2 comments	Download
M	state/watcher.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM. I'm not completely clear on the migration implications, I guess we just get the ...

10 years, 1 month ago (2014-03-19 16:34:32 UTC) #3

rog

10 years, 1 month ago (2014-03-19 16:36:36 UTC) #4

I don't think there are any migration implications. The document isn't used by
anything yet.

https://codereview.appspot.com/77820043/diff/40001/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/77820043/diff/40001/state/state_test.go#newcod...
state/state_test.go:2898: },
On 2014/03/19 16:34:33, gz wrote:
> Port defaults to 0 here? What does that mean?

it means i should set it to something :-)

Expand All Messages | Collapse All Messages