R=fullung for testing Fixes issue 5005 On Tue, Mar 12, 2013 at 4:59 PM, <bradfitz@golang.org> ...
11 years, 2 months ago
(2013-03-13 00:01:59 UTC)
#2
R=fullung for testing
Fixes issue 5005
On Tue, Mar 12, 2013 at 4:59 PM, <bradfitz@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: less flaky leaking goroutine test
>
> Please review this at
https://codereview.appspot.**com/7777043/<https://codereview.appspot.com/7777...
>
> Affected files:
> M src/pkg/net/http/client_test.**go
> M src/pkg/net/http/fs_test.go
> M src/pkg/net/http/serve_test.go
> M src/pkg/net/http/sniff_test.go
> M src/pkg/net/http/transport_**test.go
> M src/pkg/net/http/z_last_test.**go
>
>
>
On Tue, Mar 12, 2013 at 5:07 PM, <adg@golang.org> wrote: > LGTM > > Looks ...
11 years, 2 months ago
(2013-03-13 00:33:20 UTC)
#4
On Tue, Mar 12, 2013 at 5:07 PM, <adg@golang.org> wrote:
> LGTM
>
> Looks more reliable.
>
But it always was for me anyway, so I'll wait for fullung to beat on it.
> src/pkg/net/http/z_last_test.**go:49: func postTest(t *testing.T) {
> postTest seems like it could be conflated with tests about POST requests
>
> checkSideEffects ?
>
But it also does some clean-up (closing the default transport's idle
connections). So it's some cleanup & some side effect checking. It's like
"testCleanupAndCheckLeaks", but that's long. Suggestions welcome.
afterTest ? On 13 March 2013 11:33, Brad Fitzpatrick <bradfitz@golang.org> wrote: > On Tue, Mar ...
11 years, 2 months ago
(2013-03-13 00:42:43 UTC)
#5
afterTest ?
On 13 March 2013 11:33, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> On Tue, Mar 12, 2013 at 5:07 PM, <adg@golang.org> wrote:
>
>> LGTM
>>
>> Looks more reliable.
>>
>
> But it always was for me anyway, so I'll wait for fullung to beat on it.
>
>
>
>> src/pkg/net/http/z_last_test.**go:49: func postTest(t *testing.T) {
>> postTest seems like it could be conflated with tests about POST requests
>>
>> checkSideEffects ?
>>
>
> But it also does some clean-up (closing the default transport's idle
> connections). So it's some cleanup & some side effect checking. It's like
> "testCleanupAndCheckLeaks", but that's long. Suggestions welcome.
>
>
Issue 7777043: code review 7777043: net/http: less flaky leaking goroutine test
(Closed)
Created 11 years, 2 months ago by bradfitz
Modified 11 years, 2 months ago
Reviewers:
Base URL:
Comments: 1