Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(535)

Issue 7776043: code review 7776043: net: require of both -external and -ipv6 flags to run I... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by mikio
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net
Visibility:
Public.

Description

net: require of both -external and -ipv6 flags to run IPv6 multicast tests On BSD variants, the tests need surely constructed IPv6 routing table.

Patch Set 1 #

Patch Set 2 : diff -r a81eca2d85b3 https://code.google.com/p/go #

Patch Set 3 : diff -r a81eca2d85b3 https://code.google.com/p/go #

Patch Set 4 : diff -r a81eca2d85b3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/multicast_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 2 months ago (2013-03-12 23:53:38 UTC) #1
dave_cheney.net
On 2013/03/12 23:53:38, mikio wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
12 years, 2 months ago (2013-03-12 23:57:05 UTC) #2
mikio
On Wed, Mar 13, 2013 at 7:57 AM, <dave@cheney.net> wrote: > LGTM. Not tested, i ...
12 years, 2 months ago (2013-03-12 23:59:21 UTC) #3
mikio
12 years, 2 months ago (2013-03-13 00:00:09 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=05dc8c878026 ***

net: require of both -external and -ipv6 flags to run IPv6 multicast tests

On BSD variants, the tests need surely constructed IPv6
routing table.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7776043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b