Issue 7774044: config: added functions to access juju home

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7774044: config: added functions to access juju home (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by TheMue

Modified:
11 years, 1 month ago

Reviewers:
mp+153742

Visibility:
Public.

Description

config: added functions to access juju home This first CL introduces functions for the access to $JUJU_HOME - if set - or $HOME/.juju as fallback. The functions return the directory, allow to create a path to a file/dir in it, set it for testing purposes and restore it afterwards. A second CL will then migrate all manual access to $HOME/.juju today to the usage of the new API. https://code.launchpad.net/~themue/juju-core/016-juju-home/+merge/153742 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : config: added functions to access juju home #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	environs/config/home.go	View		1 chunk	+56 lines, -0 lines	0 comments	Download
A	environs/config/home_test.go	View		1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM with a trivial suggestion. https://codereview.appspot.com/7774044/diff/1/environs/config/home_test.go File environs/config/home_test.go (right): https://codereview.appspot.com/7774044/diff/1/environs/config/home_test.go#newcode26 environs/config/home_test.go:26: config.RestoreJujuHome() probably you don't ...

11 years, 2 months ago (2013-03-18 11:44:37 UTC) #2

TheMue

11 years, 2 months ago (2013-03-18 14:00:44 UTC) #4

*** Submitted:

config: added functions to access juju home

This first CL introduces functions for the access to
$JUJU_HOME - if set -  or $HOME/.juju as fallback. The
functions return the directory, allow to create a path
to a file/dir in it, set it for testing purposes and
restore it afterwards. A second CL will then migrate
all manual access to $HOME/.juju today to the usage
of the new API.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7774044

Expand All Messages | Collapse All Messages