Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 7769047: code review 7769047: cmd/5l: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by dave
Modified:
12 years, 1 month ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

cmd/5l: fix arm build Fixes build. One part of ../misc/cgo/test appears to be unhappy but this does not cause the build to fail.

Patch Set 1 #

Patch Set 2 : diff -r 61c9a6a83828 https://code.google.com/p/go #

Patch Set 3 : diff -r 61c9a6a83828 https://code.google.com/p/go #

Patch Set 4 : diff -r 61c9a6a83828 https://code.google.com/p/go #

Patch Set 5 : diff -r 61c9a6a83828 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/5l/obj.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
dave_cheney.net
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 1 month ago (2013-03-20 00:43:35 UTC) #1
r
LGTM
12 years, 1 month ago (2013-03-20 00:52:09 UTC) #2
dave_cheney.net
# ../misc/cgo/test # testmain only -linkmode=internal is supported FAIL _/home/dfc/go/misc/cgo/test [build failed] ^ this is ...
12 years, 1 month ago (2013-03-20 00:55:29 UTC) #3
dave_cheney.net
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2013-03-20 01:05:02 UTC) #4
dave_cheney.net
12 years, 1 month ago (2013-03-20 01:06:14 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=31ae6d73fdb0 ***

cmd/5l: fix arm build

Fixes build. One part of ../misc/cgo/test appears to be unhappy but this does
not cause the build to fail.

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/7769047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b