Issue 7767044: code review 7767044: cmd/gc: reject methods on non-locals, even if symbol exists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7767044: code review 7767044: cmd/gc: reject methods on non-locals, even if symbol exists (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by DMorsing

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: reject methods on non-locals, even if symbol exists Fixes issue 5089.

Patch Set 1 #

Patch Set 2 : diff -r 61fa5c7d741f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 61fa5c7d741f https://code.google.com/p/go/ #

Patch Set 4 : diff -r a5c202b53a58 https://code.google.com/p/go/ #

Patch Set 5 : diff -r f6f17c5b2ccd https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
	M	src/cmd/gc/dcl.c	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
	A	test/fixedbugs/issue5089.go	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-03-20 20:03:01 UTC) #1

DMorsing

12 years, 1 month ago (2013-03-20 21:19:23 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d10c038c5e62 ***

cmd/gc: reject methods on non-locals, even if symbol exists

Fixes issue 5089.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7767044

Expand All Messages | Collapse All Messages