Issue 7765047: Remove Service Click Actions/Other refactoring

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7765047: Remove Service Click Actions/Other refactoring

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by bcsaller

Modified:
11 years, 1 month ago

Reviewers:
jeff.pihach, mp+155257, matthew.scott

Visibility:
Public.

Description

Remove Service Click Actions/Other refactoring This removes the old service_click_actions structure and ports the d3 code to use maps for attr assignment where it makes sense. https://code.launchpad.net/~bcsaller/juju-gui/d3-cleanups/+merge/155257 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove Service Click Actions/Other refactoring #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+243 lines, -292 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/service.js	View	18 chunks	+223 lines, -261 lines	0 comments	Download
M	test/test_application_notifications.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/test_environment_view.js	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	test/test_service_module.js	View	8 chunks	+14 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

matthew.scott

LGTM and works well. Thanks for the cleanup, much nicer with the .attr({...}) calls!

11 years, 1 month ago (2013-03-25 15:41:07 UTC) #2

bcsaller

11 years, 1 month ago (2013-03-25 15:59:46 UTC) #4

*** Submitted:

Remove Service Click Actions/Other refactoring

This removes the old service_click_actions structure
and ports the d3 code to use maps for attr assignment 
where it makes sense.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/7765047

Expand All Messages | Collapse All Messages