Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 7762043: Add category list to charms

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by abentley-home
Modified:
9 years, 8 months ago
Reviewers:
mp+152925, fwereade, jameinel
Visibility:
Public.

Description

Add category list to charms Added category list to charms to support charmworld, which will display charm categories. While most charms will have only one, some will fit into multiple categories, such as Apache, which is both a web server and a proxy. There will be an official list of categories, but supplying an unofficial category is a lint error, not a syntax error, so this branch does not address that. The order of the values is not significant, so in Python terms categories are a set, not a list, but since none of JSON, BSON and Go has direct support for sets, a list is used. This branch also adds tests to ensure that Meta objects can be roundtripped via BSON. https://code.launchpad.net/~abentley/juju-core/categories/+merge/152925 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, --1 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charm/meta.go View 5 chunks +16 lines, -0 lines 0 comments Download
M charm/meta_test.go View 3 chunks +60 lines, -0 lines 1 comment Download
A testing/repo/series/category/.dir/ignored View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/repo/series/category/.ignored View 1 chunk +1 line, -0 lines 0 comments Download
A testing/repo/series/category/metadata.yaml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7
abentley-home
Please take a look.
11 years, 1 month ago (2013-03-12 17:58:27 UTC) #1
dave_cheney.net
On 2013/03/12 17:58:27, abentley wrote: > Please take a look. I thought format 2 was ...
11 years, 1 month ago (2013-03-13 00:37:54 UTC) #2
abentley-home
On 2013/03/13 00:37:54, dfc wrote: > On 2013/03/12 17:58:27, abentley wrote: > > Please take ...
11 years, 1 month ago (2013-03-13 12:52:29 UTC) #3
fwereade
On 2013/03/13 12:52:29, abentley wrote: > Sorry, I wasn't aware of that. What format should ...
11 years, 1 month ago (2013-03-15 15:00:37 UTC) #4
fwereade
On 2013/03/15 15:00:37, fwereade wrote: > On 2013/03/13 12:52:29, abentley wrote: > > Sorry, I ...
11 years, 1 month ago (2013-03-15 15:00:52 UTC) #5
jameinel
LGTM https://codereview.appspot.com/7762043/diff/1/charm/meta_test.go File charm/meta_test.go (right): https://codereview.appspot.com/7762043/diff/1/charm/meta_test.go#newcode317 charm/meta_test.go:317: } Yay!
11 years, 1 month ago (2013-03-18 07:20:46 UTC) #6
jameinel
11 years, 1 month ago (2013-03-19 13:31:25 UTC) #7
*** Submitted:

Add category list to charms

Added category list to charms to support charmworld, which will display charm
categories.  While most charms will have only one, some will fit into multiple
categories, such as Apache, which is both a web server and a proxy.

There will be an official list of categories, but supplying an unofficial
category is a lint error, not a syntax error, so this branch does not address
that.  The order of the values is not significant, so in Python terms
categories are a set, not a list, but since none of JSON, BSON and Go has
direct support for sets, a list is used.

This branch also adds tests to ensure that Meta objects can be roundtripped
via BSON.

R=dfc, fwereade, jameinel
CC=
https://codereview.appspot.com/7762043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b