Issue 7759050: Change to legacy node.js PPA to revert to 0.8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7759050: Change to legacy node.js PPA to revert to 0.8

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by jeff.pihach

Modified:
11 years, 1 month ago

Reviewers:
bac, mp+153617

Visibility:
Public.

Description

Change to legacy node.js PPA to revert to 0.8 https://code.launchpad.net/~hatch/charms/precise/juju-gui/conflict/+merge/153617 (do not edit description out of merge proposal)

Patch Set 2 : Change to legacy node.js PPA to revert to 0.8 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	hooks/utils.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM with changes https://codereview.appspot.com/7759050/diff/1/hooks/utils.py File hooks/utils.py (right): https://codereview.appspot.com/7759050/diff/1/hooks/utils.py#newcode79 hooks/utils.py:79: #BUILD_REPOSITORIES = ('ppa:chris-lea/node.js',) Can the commented ...

11 years, 1 month ago (2013-03-15 19:35:04 UTC) #2

jeff.pihach

Thanks for the review! https://codereview.appspot.com/7759050/diff/1/hooks/utils.py File hooks/utils.py (right): https://codereview.appspot.com/7759050/diff/1/hooks/utils.py#newcode79 hooks/utils.py:79: #BUILD_REPOSITORIES = ('ppa:chris-lea/node.js',) On 2013/03/15 ...

11 years, 1 month ago (2013-03-15 19:37:12 UTC) #3

jeff.pihach

11 years, 1 month ago (2013-03-15 19:39:57 UTC) #4

*** Submitted:

Change to legacy node.js PPA to revert to 0.8

R=bac
CC=
https://codereview.appspot.com/7759050

Expand All Messages | Collapse All Messages