Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1103)

Issue 7759048: code review 7759048: runtime: unbreak netbsd builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by jsing
Modified:
12 years, 2 months ago
Reviewers:
bsiegert
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: unbreak netbsd builds Fix signal handling so that Go builds on NetBSD.

Patch Set 1 : diff -r 5957d9d08900 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/pkg/runtime/signal_386.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/signal_amd64.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/signal_arm.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/signal_netbsd_386.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/signal_netbsd_amd64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/signal_netbsd_arm.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2013-03-15 12:52:47 UTC) #1
r
LGTM
12 years, 2 months ago (2013-03-15 14:41:48 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=9606c6225594 *** runtime: unbreak netbsd builds Fix signal handling so that Go ...
12 years, 2 months ago (2013-03-15 15:44:05 UTC) #3
bsiegert
12 years, 2 months ago (2013-03-15 15:56:57 UTC) #4
LGTM

This fixes the build on my system. Thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b