Issue 7759046: code review 7759046: runtime, net: fix arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7759046: code review 7759046: runtime, net: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

runtime, net: fix arm build Bring net/fd_linux.go back (it was deleted this morning) because it is still needed for ARM. Fix a few typos in the runtime reorg.

Patch Set 1 #

Patch Set 2 : diff -r 77e6fc536a7d https://code.google.com/p/go #

Patch Set 3 : diff -r 77e6fc536a7d https://code.google.com/p/go #

Patch Set 4 : diff -r 77e6fc536a7d https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -5 lines)			Patch
A	src/pkg/net/fd_linux.go	View	1	1 chunk	+194 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/defs_linux_arm.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/signal_arm.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/signal_linux_arm.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-03-14 19:35:21 UTC) #1

rsc

12 years ago (2013-03-14 19:43:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f067fb74c22b ***

runtime, net: fix arm build

Bring net/fd_linux.go back (it was deleted this morning)
because it is still needed for ARM.

Fix a few typos in the runtime reorg.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7759046

Expand All Messages | Collapse All Messages