cmd/jujud: upgrader skips unnecessary downloads

cmd/jujud: upgrader skips unnecessary downloads

kinda trivial, but I couldn't figure out how to write a test case. Not
really keen toput in any more time on this, just saw it lying around --
I'm fine either submitting or rejecting as is.

Agreed that a better-factored loop would simplify this a lot and make it
more testable; also agree out of scope.

https://code.launchpad.net/~fwereade/juju-core/upgrader-save-unnecessary-download/+merge/153378

(do not edit description out of merge proposal)

[fwereade, 2013-03-14 14:37:21]

Please take a look.

[dave_cheney.net, 2013-03-14 21:44:10]

LGTM if you say so.

https://codereview.appspot.com/7755045/diff/1/cmd/jujud/upgrade.go
File cmd/jujud/upgrade.go (right):

https://codereview.appspot.com/7755045/diff/1/cmd/jujud/upgrade.go#newcode179
cmd/jujud/upgrade.go:179: // The perfect tools have already been downloaded, so
use them.
s/perfect/exact/

[jameinel, 2013-03-17 11:13:59]

LGTM. Better to be landed than not, though I feel the reason it is hard to test
is because the function got too big. If the individual cases were helper
functions then you could at least unit test its behavior (put stuff in a dir,
trigger the request for new tools, prevent it from reading remotely, etc.)

[thumper, 2013-03-21 22:25:26]

LTGM

I agree with John's comments about it being easier to test if the function was
broken up, but this is outside the scope of this simple change.

[thumper, 2013-03-21 22:26:16]

On 2013/03/21 22:25:26, thumper wrote:
> LTGM

LGTM even

dumb abbreviation

> I agree with John's comments about it being easier to test if the function was
> broken up, but this is outside the scope of this simple change.

[fwereade, 2013-03-22 10:49:25]

*** Submitted:

cmd/jujud: upgrader skips unnecessary downloads

kinda trivial, but I couldn't figure out how to write a test case. Not
really keen toput in any more time on this, just saw it lying around --
I'm fine either submitting or rejecting as is.

Agreed that a better-factored loop would simplify this a lot and make it
more testable; also agree out of scope.

R=dfc, jameinel, thumper
CC=
https://codereview.appspot.com/7755045

https://codereview.appspot.com/7755045/diff/1/cmd/jujud/upgrade.go
File cmd/jujud/upgrade.go (right):

https://codereview.appspot.com/7755045/diff/1/cmd/jujud/upgrade.go#newcode179
cmd/jujud/upgrade.go:179: // The perfect tools have already been downloaded, so
use them.
On 2013/03/14 21:44:10, dfc wrote:
> s/perfect/exact/

Done.