Issue 77540044: code review 77540044: expvar: don't recursively acquire Map.RLock

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77540044: code review 77540044: expvar: don't recursively acquire Map.RLock (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by bradfitz

Modified:
11 years, 2 months ago

Reviewers:
gobot, iant, dvyukov

CC:
iant, golang-codereviews

Visibility:
Public.

Description

expvar: don't recursively acquire Map.RLock Fixes Issue 7575

Patch Set 1 #

Patch Set 2 : diff -r 262af7c32d11 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 262af7c32d11 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 262af7c32d11 https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/pkg/expvar/expvar.go	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello dvyukov@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2014-03-18 18:34:31 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=5f361c5a1755 *** expvar: don't recursively acquire Map.RLock Fixes Issue 7575 LGTM=iant R=dvyukov, ...

11 years, 2 months ago (2014-03-18 18:38:45 UTC) #3

gobot

11 years, 2 months ago (2014-03-18 19:02:31 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/8eaaa0a7adc7c716aee3d7f5a89ef8b5bef33a85

Expand All Messages | Collapse All Messages