Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1789)

Issue 77490043: environs: Added Networks to StartInstanceParams

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by gz
Modified:
7 years, 8 months ago
Reviewers:
mp+211588, hduran, natefinch
Visibility:
Public.

Description

environs: Added Networks to StartInstanceParams Added to StartInstanceParams in environ/broker.go Networks is a simple struct holding two str lists defining which networks are to be included/excluded for the started instance. Networks was defined in place for the moment. Even though I added helpers to the ones already in place (for Starting instances with constraints) I did not add specific tests for the added struct. https://code.launchpad.net/~gz/juju-core/add_startinstance_params/+merge/211588 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/broker.go View 2 chunks +11 lines, -0 lines 0 comments Download
M juju/testing/instance.go View 2 chunks +26 lines, -0 lines 0 comments Download
M provider/common/bootstrap_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M provider/common/mock_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
gz
Please take a look.
7 years, 8 months ago (2014-03-18 17:28:00 UTC) #1
hduran
On 2014/03/18 17:28:00, gz wrote: > Please take a look. I reply in order to ...
7 years, 8 months ago (2014-03-18 17:30:10 UTC) #2
natefinch
7 years, 8 months ago (2014-03-19 16:36:55 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b