Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 7746050: code review 7746050: vet: fix test_deadcode.go's tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by r
Modified:
11 years ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

vet: fix test_deadcode.go's tests This is a totally mechanical change. Errors are reported for the beginning of the statement, not the end, so the errchk markers need to be on the opening brace, not the closing one. It seems this test was never run.

Patch Set 1 #

Patch Set 2 : diff -r d0b2aef77eeb https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -72 lines) Patch
M src/cmd/vet/test_deadcode.go View 24 chunks +72 lines, -72 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years ago (2013-03-27 23:22:05 UTC) #1
bradfitz
LGTM On Wed, Mar 27, 2013 at 4:22 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years ago (2013-03-27 23:27:42 UTC) #2
r
11 years ago (2013-03-27 23:30:21 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=6270bc68226e ***

vet: fix test_deadcode.go's tests
This is a totally mechanical change.
Errors are reported for the beginning of the statement, not the end,
so the errchk markers need to be on the opening brace, not the closing
one. It seems this test was never run.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7746050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b