Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13540)

Issue 7741043: Complete deploy functionality and tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by gary.poster
Modified:
11 years, 1 month ago
Reviewers:
bac, teknico, mp+152805
Visibility:
Public.

Description

Complete deploy functionality and tests. This combines three discrete improvements, each with their own commit. revno: 423 add machines for units revno: 424 add support for passing a YAML string for service configuration, as would be passed by file parsing revno: 425 add a nextChanges function and tests for it in isolation and with deploy and addUnit. Note that rev 424 uses js-yaml 2.0.3, which seems to be a lot better than previous incarnations in my small tests. I decided it was worth including. As I said in the .min.js file, I committed this to the tree rather than using npm because the file we needed was not in npm. rev 425, with the nextChanges, is the most "sketchy." We'll have to see how that fares when we actually implement the wire protocol, but I think it should work. https://code.launchpad.net/~gary/juju-gui/sandboxEnv-2/+merge/152805 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Complete deploy functionality and tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -25 lines) Patch
M .jshintrc View 1 chunk +1 line, -0 lines 0 comments Download
M Makefile View 2 chunks +4 lines, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/javascripts/js-yaml.min.js View 1 chunk +5 lines, -0 lines 0 comments Download
M app/modules-debug.js View 2 chunks +12 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 7 chunks +149 lines, -14 lines 0 comments Download
M bin/merge-files View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_fakebackend.js View 1 3 chunks +160 lines, -9 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
11 years, 1 month ago (2013-03-12 00:40:15 UTC) #1
teknico
LGTM
11 years, 1 month ago (2013-03-12 12:41:53 UTC) #2
bac
LGTM modulo a couple of changes. Before we'd not done any YAML parsing in JS ...
11 years, 1 month ago (2013-03-12 12:50:57 UTC) #3
gary.poster
11 years, 1 month ago (2013-03-12 13:50:54 UTC) #4
*** Submitted:

Complete deploy functionality and tests.

This combines three discrete improvements, each with their own commit.

revno: 423
  add machines for units

revno: 424
  add support for passing a YAML string for service configuration, as would be
passed by file parsing

revno: 425
  add a nextChanges function and tests for it in isolation and with deploy and
addUnit.

Note that rev 424 uses js-yaml 2.0.3, which seems to be a lot better than
previous incarnations in my small tests.  I decided it was worth including.  As
I said in the .min.js file, I committed this to the tree rather than using npm
because the file we needed was not in npm.

rev 425, with the nextChanges, is the most "sketchy."  We'll have to see how
that fares when we actually implement the wire protocol, but I think it should
work.

R=teknico, bac
CC=
https://codereview.appspot.com/7741043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b