code review 7732044: go/test/bench/go1: add printf and time format tests

go/test/bench/go1: add printf and time format tests
Also rename the go parser test to GoParse so it doesn't grab the globally useful Parse name.

[r, 2013-03-11 22:31:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-03-11 22:42:45]

LGTM. Thank you. 

On 12/03/2013, at 9:31, r@golang.org wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go
> 
> 
> Description:
> go/test/bench/go1: add printf and time format tests
> Also rename the go parser test to GoParse so it doesn't grab the
> globally useful Parse name.
> 
> Please review this at https://codereview.appspot.com/7732044/
> 
> Affected files:
>  A test/bench/go1/fmt_test.go
>  M test/bench/go1/parser_test.go
>  A test/bench/go1/time_test.go
> 
> 
> Index: test/bench/go1/fmt_test.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/bench/go1/fmt_test.go
> @@ -0,0 +1,68 @@
> +// Copyright 2013 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package go1
> +
> +// benchmark based on fmt/fmt_test.go
> +
> +import (
> +    "bytes"
> +    "fmt"
> +    "testing"
> +)
> +
> +func BenchmarkFmtFprintfEmpty(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        fmt.Fprintf(&buf, "")
> +    }
> +}
> +
> +func BenchmarkFmtFprintfString(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        buf.Reset()
> +        fmt.Fprintf(&buf, "%s", "hello")
> +    }
> +}
> +
> +func BenchmarkFmtFprintfInt(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        buf.Reset()
> +        fmt.Fprintf(&buf, "%d", 5)
> +    }
> +}
> +
> +func BenchmarkFmtFprintfIntInt(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        buf.Reset()
> +        fmt.Fprintf(&buf, "%d %d", 5, 6)
> +    }
> +}
> +
> +func BenchmarkFmtFprintfPrefixedInt(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        buf.Reset()
> +        fmt.Fprintf(&buf, "This is some meaningless prefix text that needs to
be scanned %d", 6)
> +    }
> +}
> +
> +func BenchmarkFmtFprintfFloat(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        buf.Reset()
> +        fmt.Fprintf(&buf, "%g", 5.23184)
> +    }
> +}
> +
> +func BenchmarkFmtManyArgs(b *testing.B) {
> +    var buf bytes.Buffer
> +    for i := 0; i < b.N; i++ {
> +        buf.Reset()
> +        fmt.Fprintf(&buf, "%2d/%2d/%2d %d:%d:%d %s %s\n", 3, 4, 5, 11, 12,
13, "hello", "world")
> +    }
> +}
> Index: test/bench/go1/parser_test.go
> ===================================================================
> --- a/test/bench/go1/parser_test.go
> +++ b/test/bench/go1/parser_test.go
> @@ -33,7 +33,7 @@
>    return b
> }
> 
> -func BenchmarkParse(b *testing.B) {
> +func BenchmarkGoParse(b *testing.B) {
>    b.SetBytes(int64(len(parserbytes)))
>    for i := 0; i < b.N; i++ {
>        if _, err := parser.ParseFile(token.NewFileSet(), "", parserbytes,
parser.ParseComments); err != nil {
> Index: test/bench/go1/time_test.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/bench/go1/time_test.go
> @@ -0,0 +1,25 @@
> +// Copyright 2013 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package go1
> +
> +// benchmark based on time/time_test.go
> +
> +import (
> +    "testing"
> +    "time"
> +)
> +
> +func BenchmarkTimeParse(b *testing.B) {
> +    for i := 0; i < b.N; i++ {
> +        time.Parse(time.ANSIC, "Mon Jan  2 15:04:05 2006")
> +    }
> +}
> +
> +func BenchmarkTimeFormat(b *testing.B) {
> +    t := time.Unix(1265346057, 0)
> +    for i := 0; i < b.N; i++ {
> +        t.Format("Mon Jan  2 15:04:05 2006")
> +    }
> +}
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[r, 2013-03-12 00:17:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=7006614f0720 ***

go/test/bench/go1: add printf and time format tests
Also rename the go parser test to GoParse so it doesn't grab the globally useful
Parse name.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7732044