Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1602)

Issue 77300044: Use juju-mongodb on trusty.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by thumper
Modified:
10 years, 1 month ago
Reviewers:
mp+211642, dave, wallyworld
Visibility:
Public.

Description

Use juju-mongodb on trusty. This branch does the simplest thing that can work. For trusty, juju-mongodb is always used, for other series mongodb-server is used. This does mean that the local provider on trusty will now depend on juju-mongodb. James Page is aware, and will make the dependency required for the juju-local package when we tell him. Tested on the local provider on trusty, and ec2 using precise. https://code.launchpad.net/~thumper/juju-core/juju-mongodb/+merge/211642 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -26 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/mongo/mongo.go View 4 chunks +27 lines, -3 lines 3 comments Download
M agent/mongo/mongo_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/cloudinit/cloudinit.go View 2 chunks +24 lines, -17 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 3
thumper
Please take a look.
10 years, 1 month ago (2014-03-18 22:28:42 UTC) #1
wallyworld
LGTM but there's no test for the trusty vs non trusty specific content of cloud ...
10 years, 1 month ago (2014-03-18 22:51:07 UTC) #2
dave_cheney.net
10 years, 1 month ago (2014-03-19 02:58:45 UTC) #3
LGTM with one minor comment

https://codereview.appspot.com/77300044/diff/1/agent/mongo/mongo.go
File agent/mongo/mongo.go (right):

https://codereview.appspot.com/77300044/diff/1/agent/mongo/mongo.go#newcode35
agent/mongo/mongo.go:35: if series == "trusty" {
I don't like the idea that we have to remember to update this in 7 months.

How about

switch series {
case "precise", "raring", "saucy":
    return "mongodb-server"
default:
    // trusty and onwards
    return :juju-mongodb"
}

https://codereview.appspot.com/77300044/diff/1/agent/mongo/mongo.go#newcode47
agent/mongo/mongo.go:47: return MongodbServerPath
same as above
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b