code review 77300043: strconv: CanBackquote should reject \x7F

strconv: CanBackquote should reject \x7F
It's a control character.
Fixes issue 7565.

[r, 2014-03-18 06:04:45]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-03-18 06:17:26]

LGTM



On Mon, Mar 17, 2014 at 11:04 PM, <r@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> strconv: CanBackquote should reject \x7F
> It's a control character.
> Fixes issue 7565.
>
> Please review this at https://codereview.appspot.com/77300043/
>
> Affected files (+3, -1 lines):
>   M src/pkg/strconv/quote.go
>   M src/pkg/strconv/quote_test.go
>
>
> Index: src/pkg/strconv/quote.go
> ===================================================================
> --- a/src/pkg/strconv/quote.go
> +++ b/src/pkg/strconv/quote.go
> @@ -144,7 +144,8 @@
>  // characters other than space and tab.
>  func CanBackquote(s string) bool {
>         for i := 0; i < len(s); i++ {
> -               if (s[i] < ' ' && s[i] != '\t') || s[i] == '`' {
> +               c := s[i]
> +               if (c < ' ' && c != '\t') || c == '`' || c == '\u007F' {
>                         return false
>                 }
>         }
> Index: src/pkg/strconv/quote_test.go
> ===================================================================
> --- a/src/pkg/strconv/quote_test.go
> +++ b/src/pkg/strconv/quote_test.go
> @@ -140,6 +140,7 @@
>         {string(29), false},
>         {string(30), false},
>         {string(31), false},
> +       {string(0x7F), false},
>         {`' !"#$%&'()*+,-./:;<=>?@[\]^_{|}~`, true},
>         {`0123456789`, true},
>         {`ABCDEFGHIJKLMNOPQRSTUVWXYZ`, true},
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-03-18 23:16:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=50cee9f42671 ***

strconv: CanBackquote should reject \x7F
It's a control character.
Fixes issue 7565.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/77300043

[gobot, 2014-03-18 23:19:30]

This CL appears to have broken the linux-amd64 builder.
See http://build.golang.org/log/0680b2cfd0205bc71459f1a636e61815f92e10fe