Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2180)

Issue 7727045: state: add allWatcher.handle method

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by rog
Modified:
6 years, 8 months ago
Reviewers:
mp+153209, dimitern, fwereade
Visibility:
Public.

Description

state: add allWatcher.handle method This handles a request from a StateWatcher and adds the request to the set of outstanding requests as appropriate. https://code.launchpad.net/~rogpeppe/juju-core/242-allwatcher-handle/+merge/153209 Requires: https://code.launchpad.net/~rogpeppe/juju-core/241-allwatcher-changed/+merge/153203 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add allWatcher.handle method #

Patch Set 3 : state: add allWatcher.handle method #

Total comments: 2

Patch Set 4 : state: add allWatcher.handle method #

Patch Set 5 : state: add allWatcher.handle method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -2 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M state/megawatcher.go View 1 2 3 4 4 chunks +53 lines, -2 lines 0 comments Download
M state/megawatcher_internal_test.go View 1 2 3 4 2 chunks +91 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rog
Please take a look.
6 years, 8 months ago (2013-03-13 17:52:50 UTC) #1
rog
Please take a look.
6 years, 8 months ago (2013-03-13 18:47:48 UTC) #2
dimitern
LGTM, one question. https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go#newcode105 state/megawatcher.go:105: reply chan bool why not just ...
6 years, 8 months ago (2013-03-13 20:26:34 UTC) #3
rog
https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go#newcode105 state/megawatcher.go:105: reply chan bool On 2013/03/13 20:26:34, dimitern wrote: > ...
6 years, 8 months ago (2013-03-14 12:07:53 UTC) #4
rog
Please take a look.
6 years, 8 months ago (2013-03-14 12:19:04 UTC) #5
fwereade
On 2013/03/14 12:19:04, rog wrote: > Please take a look. LGTM.
6 years, 8 months ago (2013-03-14 12:22:01 UTC) #6
rog
6 years, 8 months ago (2013-03-14 13:09:46 UTC) #7
*** Submitted:

state: add allWatcher.handle method

This handles a request from a StateWatcher
and adds the request to the set of outstanding
requests as appropriate.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7727045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b