Issue 7727045: state: add allWatcher.handle method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7727045: state: add allWatcher.handle method

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
mp+153209, dimitern, fwereade

Visibility:
Public.

Description

state: add allWatcher.handle method This handles a request from a StateWatcher and adds the request to the set of outstanding requests as appropriate. https://code.launchpad.net/~rogpeppe/juju-core/242-allwatcher-handle/+merge/153209 Requires: https://code.launchpad.net/~rogpeppe/juju-core/241-allwatcher-changed/+merge/153203 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add allWatcher.handle method #

Patch Set 3 : state: add allWatcher.handle method #

Total comments: 2

Patch Set 4 : state: add allWatcher.handle method #

Patch Set 5 : state: add allWatcher.handle method #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -2 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/megawatcher.go	View	1 2 3 4	4 chunks	+53 lines, -2 lines	0 comments	Download
M	state/megawatcher_internal_test.go	View	1 2 3 4	2 chunks	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dimitern

LGTM, one question. https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go#newcode105 state/megawatcher.go:105: reply chan bool why not just ...

11 years, 1 month ago (2013-03-13 20:26:34 UTC) #3

rog

https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go File state/megawatcher.go (right): https://codereview.appspot.com/7727045/diff/5001/state/megawatcher.go#newcode105 state/megawatcher.go:105: reply chan bool On 2013/03/13 20:26:34, dimitern wrote: > ...

11 years, 1 month ago (2013-03-14 12:07:53 UTC) #4

fwereade

On 2013/03/14 12:19:04, rog wrote: > Please take a look. LGTM.

11 years, 1 month ago (2013-03-14 12:22:01 UTC) #6

rog

11 years, 1 month ago (2013-03-14 13:09:46 UTC) #7

*** Submitted:

state: add allWatcher.handle method

This handles a request from a StateWatcher
and adds the request to the set of outstanding
requests as appropriate.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7727045

Expand All Messages | Collapse All Messages