|
Fix bootstrap tools issues
These bugs are addressed:
lp:1227722 - tools for wrong arch
lp:1282870 - cannot use constraints to select tools
lp:1282869 - bad failure mode for incorrect arch
tl;dr; you can bootstrap environments which run on
architectures which are different to the client
machine architcture, so long as tools are available.
eg ppc client boottrapping an environment on EC2.
Other error conditions are also addressed eg you cannot
upload tools to a cloud if that cloud does not support
the client machine architecture, since that's what the
uploaded tools would be built for. You also cannot
specify an arch constraint different to your client
machine if you are uploading tools.
A lot of the tools logic was duplicated. It has been
refactoroed to used shared code. There's still more
to do however since it's still possible to do bad things
with upgrade-juju.
https://code.launchpad.net/~wallyworld/juju-core/bootstrap-tools-fixes/+merge/211449
(do not edit description out of merge proposal)
Total comments: 13
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+540 lines, -188 lines) |
Patch |
|
A |
[revision details]
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
agent/tools/tools_test.go
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
cmd/juju/bootstrap.go
|
View
|
|
4 chunks |
+1 line, -41 lines |
0 comments
|
Download
|
|
M |
cmd/juju/bootstrap_test.go
|
View
|
1
|
12 chunks |
+59 lines, -20 lines |
0 comments
|
Download
|
|
M |
cmd/juju/upgradejuju.go
|
View
|
1
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
cmd/package_test.go
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
environs/bootstrap/bootstrap_test.go
|
View
|
1
|
11 chunks |
+198 lines, -11 lines |
0 comments
|
Download
|
|
M |
environs/bootstrap/synctools.go
|
View
|
1
|
5 chunks |
+92 lines, -46 lines |
0 comments
|
Download
|
|
M |
environs/interface.go
|
View
|
|
3 chunks |
+12 lines, -1 line |
0 comments
|
Download
|
|
M |
environs/manual/init.go
|
View
|
1
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
environs/testing/tools.go
|
View
|
|
3 chunks |
+18 lines, -13 lines |
0 comments
|
Download
|
|
M |
environs/tools/tools_test.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
juju/arch/arch.go
|
View
|
1
|
2 chunks |
+13 lines, -15 lines |
0 comments
|
Download
|
|
M |
juju/arch/arch_test.go
|
View
|
1
|
3 chunks |
+5 lines, -9 lines |
0 comments
|
Download
|
|
M |
provider/azure/environ.go
|
View
|
|
2 chunks |
+8 lines, -3 lines |
0 comments
|
Download
|
|
M |
provider/azure/environ_test.go
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/common/bootstrap.go
|
View
|
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
provider/common/bootstrap_test.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
provider/common/mock_test.go
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/dummy/environs.go
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/ec2/ec2.go
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/ec2/local_test.go
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/joyent/environ.go
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/local/environ.go
|
View
|
1
|
2 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/local/environ_test.go
|
View
|
|
2 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/maas/environ.go
|
View
|
1
|
2 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/maas/environ_test.go
|
View
|
1
|
3 chunks |
+10 lines, -2 lines |
0 comments
|
Download
|
|
M |
provider/maas/environ_whitebox_test.go
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
provider/manual/environ.go
|
View
|
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/manual/environ_test.go
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/openstack/local_test.go
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
provider/openstack/provider.go
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
version/version.go
|
View
|
1
|
3 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
Total messages: 4
|