Planeshift contributor patch bug 1137, console error opening spell book

Patch by peeg removing error in console when opening spell book. Tested by Vornne.
http://www.hydlaa.com/flyspray_upgrade/index.php?do=details&task_id=1137&project=2&order=status&sort=desc

(for some reason this did not go to the review group before)

[Lanarel, 2008-11-01 18:11:07]

Redid patch as it did not parse

[weltall2, 2008-11-01 20:09:27]

might be better to reduce if elses?

http://codereview.appspot.com/7724/diff/4/201
File src/client/gui/pawsspellbookwindow.cpp (right):

http://codereview.appspot.com/7724/diff/4/201#newcode131
Line 131: break;
wouldn't it be better if the check was

if(!mesg.spells[x].glyphs[i])
  break

glyph->SetBackground(mesg.spells[x].glyphs[i]);

[Lanarel, 2008-11-02 00:00:53]

http://codereview.appspot.com/7724/diff/4/201
File src/client/gui/pawsspellbookwindow.cpp (right):

http://codereview.appspot.com/7724/diff/4/201#newcode124
Line 124: pawsWidget* glyph = (pawsWidget*)row->GetColumn(1+i);
I would move this line after the if, since glyph is only used
if(mesg.spells[x].glyphs[i])

http://codereview.appspot.com/7724/diff/4/201#newcode131
Line 131: break;
Saves a few lines :)

[Peeg, 2008-11-07 21:04:58]

Thanks for the input :)

http://paste.frubar.net/9285/txt