Build the date during the test

Build the date during the test

Because we aren't using UTC time we need to build the
date to check against in the test so that it can be
run across the dateline.

https://code.launchpad.net/~hatch/juju-gui/tz-test/+merge/155006

(do not edit description out of merge proposal)

[jeff.pihach, 2013-03-22 16:25:43]

Please take a look.

[rharding, 2013-03-22 16:33:51]

lgtm

[gary.poster, 2013-03-22 16:58:06]

LGTM with changes.

Thank you for fixing this!

Gary

https://codereview.appspot.com/7722045/diff/1/test/test_charm_panel.js
File test/test_charm_panel.js (right):

https://codereview.appspot.com/7722045/diff/1/test/test_charm_panel.js#newcod...
test/test_charm_panel.js:317: var cd = new Date(1349797266.032 * 1000),
small: I suggest setting the float as a variable at the top of the test and then
using the variable in "created" and here.  I think the connection/source would
be slightly clearer.

https://codereview.appspot.com/7722045/diff/1/test/test_charm_panel.js#newcod...
test/test_charm_panel.js:324: checkedDate = cd.getFullYear() + '-' + month + '-'
+ date;
I suggest replacing all of the above with "Y.Date.format(cd, '%F')."

For context, see "<div>{{dateformat created "%F"}}</div>" in
app/templates/charm-description.handlebars and
"Y.Handlebars.registerHelper('dateformat'..." in app/views/utils.py

[jeff.pihach, 2013-03-22 22:05:51]

On 2013/03/22 16:58:06, gary.poster wrote:
> LGTM with changes.
> 
> Thank you for fixing this!
> 
> Gary
> 
> https://codereview.appspot.com/7722045/diff/1/test/test_charm_panel.js
> File test/test_charm_panel.js (right):
> 
>
https://codereview.appspot.com/7722045/diff/1/test/test_charm_panel.js#newcod...
> test/test_charm_panel.js:317: var cd = new Date(1349797266.032 * 1000),
> small: I suggest setting the float as a variable at the top of the test and
then
> using the variable in "created" and here.  I think the connection/source would
> be slightly clearer.

done.

>
https://codereview.appspot.com/7722045/diff/1/test/test_charm_panel.js#newcod...
> test/test_charm_panel.js:324: checkedDate = cd.getFullYear() + '-' + month +
'-'
> + date;
> I suggest replacing all of the above with "Y.Date.format(cd, '%F')."
> 
> For context, see "<div>{{dateformat created "%F"}}</div>" in
> app/templates/charm-description.handlebars and
> "Y.Handlebars.registerHelper('dateformat'..." in app/views/utils.py
done.


Thanks a lot for the reviews!

[jeff.pihach, 2013-03-22 22:16:05]

*** Submitted:

Build the date during the test

Because we aren't using UTC time we need to build the
date to check against in the test so that it can be
run across the dateline.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/7722045