Placed GUI callbacks under the :gui: namespace

Placed GUI callbacks under the :gui: namespace

In order to maintain proper history management and
to maintain state across charmstore and gui namespace
it was necessary to place the GUI callbacks under the
:gui: namespace with the exception of the root environment
as that should always be rendered.

https://code.launchpad.net/~hatch/juju-gui/ns-routing/+merge/154462

(do not edit description out of merge proposal)

[jeff.pihach, 2013-03-20 18:18:19]

Please take a look.

[gary.poster, 2013-03-20 18:26:25]

Preliminary review: looks good.  Trivial comments below.  I will try it out with
some QA before I give it a stamp of approval in a follow-up.

https://codereview.appspot.com/7719052/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/7719052/diff/1/app/app.js#newcode387
app/app.js:387: // Halts the default naviation on the juju logo to allow us to
show
trivial: navigation

https://codereview.appspot.com/7719052/diff/1/app/app.js#newcode499
app/app.js:499: _nsRouter: this._nsRouter });
why underlined?  It's not protected.  I'd remove the underlines from both the
app attribute (pre-existing to your branch) and the argument (from this branch).
 Same for any others, like the one below in _buildServiceView.

https://codereview.appspot.com/7719052/diff/1/app/app.js#newcode770
app/app.js:770: @method showRootViewinit
trivial: showRootView

https://codereview.appspot.com/7719052/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/7719052/diff/1/app/views/environment.js#newcode74
app/views/environment.js:74: _nsRouter: this.get('_nsRouter')});
Yes, death to the preceding underline...

https://codereview.appspot.com/7719052/diff/1/app/views/unit.js
File app/views/unit.js (right):

https://codereview.appspot.com/7719052/diff/1/app/views/unit.js#newcode346
app/views/unit.js:346: _nsRouter: {}
DEATH! :-)

[matthew.scott, 2013-03-20 19:05:18]

LGTM with QA issues fixed.  Thanks.

[jeff.pihach, 2013-03-20 21:13:18]

Please take a look.

[jeff.pihach, 2013-03-20 23:14:10]

Please take a look.

[gary.poster, 2013-03-20 23:28:18]

LGTM.

Thanks for your very hard and good work on this, Jeff.

Take my comments with a grain of salt--especially the ones about the ../../
stuff.  If you have a reason for doing what you did (are we relative everywhere
else already and I just haven't noticed?) just proceed.

Gary

https://codereview.appspot.com/7719052/diff/7001/app/templates/service-relati...
File app/templates/service-relations.handlebars (right):

https://codereview.appspot.com/7719052/diff/7001/app/templates/service-relati...
app/templates/service-relations.handlebars:27: <a
href="{{../../serviceRemoteUri}}{{far.service}}/">{{far.service}}</a>
/ instead?  not sure.

https://codereview.appspot.com/7719052/diff/7001/app/templates/unit.handlebars
File app/templates/unit.handlebars (right):

https://codereview.appspot.com/7719052/diff/7001/app/templates/unit.handlebar...
app/templates/unit.handlebars:84: <a
href="{{../../serviceRootUri}}{{far.service}}/relations">{{far.service}}</a>
Could we just have / instead?  Maybe this is safer.

https://codereview.appspot.com/7719052/diff/9006/app/app.js
File app/app.js (right):

https://codereview.appspot.com/7719052/diff/9006/app/app.js#newcode699
app/app.js:699: this.show_login();
A comment about the weird circumstances that triggered the problem that made
this necessary might be valuable.

[jeff.pihach, 2013-03-21 14:43:49]

*** Submitted:

Placed GUI callbacks under the :gui: namespace

In order to maintain proper history management and
to maintain state across charmstore and gui namespace
it was necessary to place the GUI callbacks under the
:gui: namespace with the exception of the root environment
as that should always be rendered.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7719052