Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 7719045: decode: add some flags for windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by jameinel
Modified:
11 years, 1 month ago
Reviewers:
dimitern, mp+153284, niemeyer
Visibility:
Public.

Description

decode: add some flags for windows We are doing a static compile of libyaml, so set the YAML_STATIC_DECLARE compile macro. Also, strdup is only available in the common run time (CRT) as _strdup, so use another macro for that. We could do it in other ways if there is something more appropriate for the yaml library. Originally I was doing it in an #ifdef macro, but this makes it nice and minimal and doesn't touch the yaml files directly. https://code.launchpad.net/~jameinel/goyaml/windows/+merge/153284 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : decode: add some flags for windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M decode.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
jameinel
Please take a look.
11 years, 1 month ago (2013-03-14 05:20:37 UTC) #1
dimitern
LGTM
11 years, 1 month ago (2013-03-22 13:22:33 UTC) #2
niemeyer
Can't test, but LGTM assuming it works.
11 years, 1 month ago (2013-03-25 14:32:29 UTC) #3
niemeyer
I've added you to the goyaml team, John.
11 years, 1 month ago (2013-03-25 14:34:19 UTC) #4
jameinel
11 years, 1 month ago (2013-03-26 11:01:07 UTC) #5
*** Submitted:

decode: add some flags for windows

We are doing a static compile of libyaml, so set the
YAML_STATIC_DECLARE compile macro. Also, strdup
is only available in the common run time (CRT) as
_strdup, so use another macro for that.

We could do it in other ways if there is something
more appropriate for the yaml library. Originally I
was doing it in an #ifdef macro, but this makes it
nice and minimal and doesn't touch the yaml files
directly.

R=
CC=
https://codereview.appspot.com/7719045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b