Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(273)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7716045: api: mark more things @Experimental and remove unused "Warning" from package-info.java (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by yanivi
Modified:
13 years, 6 months ago
Reviewers:
peleyal
CC:
ngmiceli, rmistry
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

api: mark more things @Experimental and remove unused "Warning" from package-info.java

Patch Set 1 #

Patch Set 2 : minor #

Total comments: 8

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -87 lines) Patch
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client-java6/src/main/java/com/google/api/client/googleapis/extensions/java6/auth/oauth2/package-info.java View 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java View 1 chunk +0 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/apache/package-info.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java View 1 2 2 chunks +20 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java View 14 chunks +37 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdToken.java View 3 chunks +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdTokenVerifier.java View 18 chunks +4 lines, -14 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleTokenResponse.java View 2 chunks +7 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/package-info.java View 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/batch/json/package-info.java View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/batch/package-info.java View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java View 1 chunk +2 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/javanet/package-info.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonResponseException.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonRpcHttpTransport.java View 6 chunks +7 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/package-info.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/media/package-info.java View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/package-info.java View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/json/package-info.java View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/package-info.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecretsTest.java View 1 3 chunks +13 lines, -1 line 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/json/GoogleJsonErrorContainerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/json/GoogleJsonErrorTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
yanivi
13 years, 7 months ago (2013-03-15 16:17:50 UTC) #1
peleyal
https://codereview.appspot.com/7716045/diff/3001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java (left): https://codereview.appspot.com/7716045/diff/3001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java#oldcode26 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java:26: ditto https://codereview.appspot.com/7716045/diff/3001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java (right): https://codereview.appspot.com/7716045/diff/3001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java#newcode189 google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java:189: @Deprecated @Experimental ...
13 years, 7 months ago (2013-03-20 14:12:56 UTC) #2
yanivi
https://codereview.appspot.com/7716045/diff/3001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java (left): https://codereview.appspot.com/7716045/diff/3001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java#oldcode26 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/package-info.java:26: On 2013/03/20 14:12:56, peleyal wrote: > ditto Done. https://codereview.appspot.com/7716045/diff/3001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java ...
13 years, 6 months ago (2013-03-25 16:06:20 UTC) #3
peleyal
13 years, 6 months ago (2013-03-27 08:22:45 UTC) #4 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b