Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(245)

Issue 77140045: code review 77140045: ogle: allow multi-valued expressions such as regular ex... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by r
Modified:
7 years, 8 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: allow multi-valued expressions such as regular expressions Allows us to set a group of breakpoints in a single call. Clean up expression evaluation a bit (it's still rudimentary). Fix a bug in breakpoint: need to back up the PC after the trap. Also fix a silly bug in formatting the startup error in ogleproxy. Can now trace a simple program using breakpoints.

Patch Set 1 #

Patch Set 2 : diff -r d498f00956d1 https://code.google.com/p/ogle #

Patch Set 3 : diff -r d498f00956d1 https://code.google.com/p/ogle #

Patch Set 4 : diff -r d498f00956d1 https://code.google.com/p/ogle #

Patch Set 5 : diff -r d498f00956d1 https://code.google.com/p/ogle #

Patch Set 6 : diff -r d498f00956d1 https://code.google.com/p/ogle #

Total comments: 13

Patch Set 7 : diff -r d498f00956d1 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -41 lines) Patch
M cmd/ogleproxy/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M program/client/client.go View 1 chunk +1 line, -1 line 0 comments Download
M program/program.go View 1 2 3 4 5 6 1 chunk +17 lines, -9 lines 0 comments Download
M program/proxyrpc/proxyrpc.go View 1 chunk +1 line, -1 line 0 comments Download
M program/server/ptrace.go View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M program/server/server.go View 1 2 3 4 5 6 5 chunks +83 lines, -27 lines 0 comments Download

Messages

Total messages: 5
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 8 months ago (2014-03-25 04:02:39 UTC) #1
r
Hello nigeltao@golang.org, Please take another look.
7 years, 8 months ago (2014-03-26 02:50:11 UTC) #2
nigeltao
LGTM. https://codereview.appspot.com/77140045/diff/90001/program/program.go File program/program.go (right): https://codereview.appspot.com/77140045/diff/90001/program/program.go#newcode65 program/program.go:65: // "/regexp/" Set of addresses whose symbolic names ...
7 years, 8 months ago (2014-03-26 03:41:02 UTC) #3
r
https://codereview.appspot.com/77140045/diff/90001/program/server/server.go File program/server/server.go (right): https://codereview.appspot.com/77140045/diff/90001/program/server/server.go#newcode258 program/server/server.go:258: // If we're stopped on a breakpoint, restore the ...
7 years, 8 months ago (2014-03-26 03:54:07 UTC) #4
r
7 years, 8 months ago (2014-03-26 03:54:23 UTC) #5
*** Submitted as https://code.google.com/p/ogle/source/detail?r=b032139f0204 ***

ogle: allow multi-valued expressions such as regular expressions
Allows us to set a group of breakpoints in a single call.
Clean up expression evaluation a bit (it's still rudimentary).
Fix a bug in breakpoint: need to back up the PC after the trap.
Also fix a silly bug in formatting the startup error in ogleproxy.

Can now trace a simple program using breakpoints.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/77140045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b