environs: send bootstrap constraints in cloudinit

environs: send bootstrap constraints in cloudinit

This closes the circuit, and causes the bootstrap constraints to be set as
the initial environment constraints in state.

https://code.launchpad.net/~fwereade/juju-core/bootstrap-constraints-5/+merge/153788

Requires: https://code.launchpad.net/~fwereade/juju-core/bootstrap-constraints-4/+merge/153759

(do not edit description out of merge proposal)

[fwereade, 2013-03-18 13:05:05]

Please take a look.

[jameinel, 2013-03-18 17:13:56]

overall this seems pretty straightforward
LGTM

I was a little surprised about the mem normalization, but I guess if it is
stored as integer MB, it makes enough sense.

https://codereview.appspot.com/7712046/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/7712046/diff/1/environs/jujutest/livetests.go#...
environs/jujutest/livetests.go:348: c.Assert(cons.String(), Equals, "mem=2048M")
This seems a little bit odd that the mem constraint is normalized back to M.

[thumper, 2013-03-19 01:30:24]

LGTM

https://codereview.appspot.com/7712046/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/7712046/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:43: func mustConstraints(s string)
state.Constraints {
Despite what appears to be some form of standard, I find that must* functions
hinder readability as they don't follow the standard method naming guidelines of
starting with some verb.  Personally I'd prefer "mustParseConstraints", however
I'm not going to block on any of this, just for comment.

[dimitern, 2013-03-19 09:23:39]

LGTM

https://codereview.appspot.com/7712046/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/7712046/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:43: func mustConstraints(s string)
state.Constraints {
On 2013/03/19 01:30:24, thumper wrote:
> Despite what appears to be some form of standard, I find that must* functions
> hinder readability as they don't follow the standard method naming guidelines
of
> starting with some verb.  Personally I'd prefer "mustParseConstraints",
however
> I'm not going to block on any of this, just for comment.

+1 for mustParseConstraints

[fwereade, 2013-03-20 11:47:47]

*** Submitted:

environs: send bootstrap constraints in cloudinit

This closes the circuit, and causes the bootstrap constraints to be set as
the initial environment constraints in state.

R=jameinel, thumper, dimitern
CC=
https://codereview.appspot.com/7712046

https://codereview.appspot.com/7712046/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/7712046/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:43: func mustConstraints(s string)
state.Constraints {
On 2013/03/19 09:23:39, dimitern wrote:
> On 2013/03/19 01:30:24, thumper wrote:
> > Despite what appears to be some form of standard, I find that must*
functions
> > hinder readability as they don't follow the standard method naming
guidelines
> of
> > starting with some verb.  Personally I'd prefer "mustParseConstraints",
> however
> > I'm not going to block on any of this, just for comment.
> 
> +1 for mustParseConstraints

SGTM, I hope to have a constraints.MustParse for use in similar situations
before too long but it's not a focus right now.

https://codereview.appspot.com/7712046/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/7712046/diff/1/environs/jujutest/livetests.go#...
environs/jujutest/livetests.go:348: c.Assert(cons.String(), Equals, "mem=2048M")
On 2013/03/18 17:13:56, jameinel wrote:
> This seems a little bit odd that the mem constraint is normalized back to M.

Rational laziness in the Constraints type. Not opposed to improving it, just not
very keen to focus on it until it starts generating complaints.