code review 7712045: doc: explain why cmd/go uses https for repositories and...

doc: explain why cmd/go uses https for repositories and how to work around it
Fixes issue 3418.

[hgfischer, 2013-03-15 13:46:27]

Hello golang-dev@googlegroups.com (cc: adg@golang.org,
golang-dev@googlegroups.com, r@golang.org),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-03-15 18:09:35]

I don't believe the text actually answers the question, "why https". As opposed
to what?

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html
File doc/go_faq.html (right):

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode958
doc/go_faq.html:958: </p>
unindent please. follow the style of the text around here.

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode958
doc/go_faq.html:958: </p>
delete this paragraph. it doesn't add to the explanation.

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode964
doc/go_faq.html:964: using HTTPS, <code>go get</code> also avoids common
networking related issues.
This can be much shorter, something like

Companies often permit outgoing traffic only on the standard TCP ports 80 (HTTP)
and 443 (HTTPS).

the second sentence doesn't help me understand the issue.

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode969
doc/go_faq.html:969: to work around it. For GitHub, you can follow one of this
possible solutions:
It's easy to work around this. For GitHub, try one of these solutions:

[hgfischer, 2013-03-15 19:30:56]

Hello golang-dev@googlegroups.com, r@golang.org (cc: adg@golang.org,
golang-dev@googlegroups.com),

Please take another look.

[hgfischer, 2013-03-15 19:44:41]

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html
File doc/go_faq.html (right):

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode958
doc/go_faq.html:958: </p>
On 2013/03/15 18:09:35, r wrote:
> unindent please. follow the style of the text around here.

Done.

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode958
doc/go_faq.html:958: </p>
On 2013/03/15 18:09:35, r wrote:
> delete this paragraph. it doesn't add to the explanation.

Done.

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode964
doc/go_faq.html:964: using HTTPS, <code>go get</code> also avoids common
networking related issues.
On 2013/03/15 18:09:35, r wrote:
> This can be much shorter, something like
> 
> Companies often permit outgoing traffic only on the standard TCP ports 80
(HTTP)
> and 443 (HTTPS).
> 
> the second sentence doesn't help me understand the issue.

Done.

https://codereview.appspot.com/7712045/diff/5001/doc/go_faq.html#newcode969
doc/go_faq.html:969: to work around it. For GitHub, you can follow one of this
possible solutions:
On 2013/03/15 18:09:35, r wrote:
> It's easy to work around this. For GitHub, try one of these solutions:

Done.

[r, 2013-03-15 19:56:36]

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html
File doc/go_faq.html (right):

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode959
doc/go_faq.html:959: default, providing protection against Man-in-the-middle,
eavesdropping and tampering attacks.
s/Man/man/

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode959
doc/go_faq.html:959: default, providing protection against Man-in-the-middle,
eavesdropping and tampering attacks.
Add,

"The <code>go</code> <code>get</code> command therefore uses <code>HTTPS</code>
for safety.

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode963
doc/go_faq.html:963: It's easy to work around this. For GitHub, try one of these
solutions:
work around what? you've answered the question now (thanks!) but i don't know
what the issue is. why not just use HTTPS?

i don't use git so i may be missing something obvious, but please explain.

[hgfischer, 2013-03-15 20:16:50]

Please see comments before I publish my changes.

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html
File doc/go_faq.html (right):

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode959
doc/go_faq.html:959: default, providing protection against Man-in-the-middle,
eavesdropping and tampering attacks.
On 2013/03/15 19:56:36, r wrote:
> s/Man/man/

Done.

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode959
doc/go_faq.html:959: default, providing protection against Man-in-the-middle,
eavesdropping and tampering attacks.
On 2013/03/15 19:56:36, r wrote:
> Add,
> 
> "The <code>go</code> <code>get</code> command therefore uses
<code>HTTPS</code>
> for safety.

Ok. I've also included "TCP port 22 (ssh)" in the blocked ports list.

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode963
doc/go_faq.html:963: It's easy to work around this. For GitHub, try one of these
solutions:
On 2013/03/15 19:56:36, r wrote:
> work around what? you've answered the question now (thanks!) but i don't know
> what the issue is. why not just use HTTPS?
> 
> i don't use git so i may be missing something obvious, but please explain. 

I see. Does this makes sense to you?

"If you use <code>git</code> and prefer to push changes through SSH by using
your
existing keypair it's easy to work around this. For GitHub, try one of these
solutions:"

[r, 2013-03-15 20:22:20]

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html
File doc/go_faq.html (right):

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode963
doc/go_faq.html:963: It's easy to work around this. For GitHub, try one of these
solutions:
that's great, thanks.

s/by using/using/
s/keypair/key pair/ or maybe just /key/

https://codereview.appspot.com/7712045/diff/14001/doc/go_faq.html#newcode971
doc/go_faq.html:971: <li>Force <code>git push</code> to always use git protocol
by appending
s|to always use git protocol|to use the <code>git</code> protocol always|

[hgfischer, 2013-03-15 20:30:04]

Hello golang-dev@googlegroups.com, r@golang.org (cc: adg@golang.org,
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-03-15 20:35:42]

LGTM
thanks

[r, 2013-03-15 20:43:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=05062dccbb4e ***

doc: explain why cmd/go uses https for repositories and how to work around it
Fixes issue 3418.

R=golang-dev, r
CC=adg, golang-dev
https://codereview.appspot.com/7712045

Committer: Rob Pike <r@golang.org>