Issue 7712044: code review 7712044: all: remove now-unnecessary unreachable panics

Issue 7712044: code review 7712044: all: remove now-unnecessary unreachable panics (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:
rsc

CC:
golang-dev, r, gri

Visibility:
Public.

Description

all: remove now-unnecessary unreachable panics Take advantage of the new terminating statement rule.

Patch Set 1 #

Patch Set 2 : diff -r e1862d179017 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e1862d179017 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6db3ee1a6ff3 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -39 lines)			Patch
M	src/cmd/api/goapi.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/go/build.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/bufio/bufio.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/bufio/scan.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/compress/bzip2/huffman.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/compress/flate/deflate_test.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/compress/flate/inflate.go	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/compress/flate/token.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/compress/lzw/reader.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/crypto/dsa/dsa.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/x509/pkcs8.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/encoding/ascii85/ascii85.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/encoding/binary/varint.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/encoding/csv/reader.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/encoding/json/decode.go	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	src/pkg/encoding/xml/read.go	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/go/parser/error_test.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/html/template/transition.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/image/gif/reader.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/math/rand/exp.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/math/rand/normal.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/mime/multipart/multipart.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/dial.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/http/client_test.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/http/fcgi/child.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/http/server.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/http/transport.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/rpc/server_test.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/net/textproto/reader.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/os/file_unix.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-11 21:06:57 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=643dc3514250 *** all: remove now-unnecessary unreachable panics Take advantage of the new ...

12 years ago (2013-03-11 21:16:58 UTC) #4

bradfitz

12 years ago (2013-03-11 22:10:29 UTC) #6

Ack.

I only did this because I was debugging something for somebody and noticed
one in net/http, so I did all of them.

On Mon, Mar 11, 2013 at 3:08 PM, Russ Cox <rsc@golang.org> wrote:

> Please be sure NOT to do this to the subrepos.
> Thanks.
>
>

Expand All Messages | Collapse All Messages