Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480)

Issue 77080043: code review 77080043: ogle: framework for communicating with proxy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by r
Modified:
7 years, 8 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: framework for communicating with proxy Interface definition for interacting with program: program/program.go Beginnings of RPC server to provide access to program: program/server/server.go Beginnings of client to talk to RPC server, plus SSH connection: program/client/client.go Beginnings of ogleproxy, which implements the RPC service: cmd/ogleproxy/main.go Transport definitions for RPC: program/proxyrpc/proxyrpc.go No tests yet - they will come when there's a little more in place. But it works, as tested by an external toy.

Patch Set 1 #

Total comments: 26

Patch Set 2 : diff -r 549f344bf0b2 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -0 lines) Patch
A cmd/ogleproxy/main.go View 1 1 chunk +75 lines, -0 lines 0 comments Download
A program/client/client.go View 1 1 chunk +221 lines, -0 lines 0 comments Download
A program/program.go View 1 1 chunk +87 lines, -0 lines 0 comments Download
A program/proxyrpc/proxyrpc.go View 1 chunk +50 lines, -0 lines 0 comments Download
A program/server/server.go View 1 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 8 months ago (2014-03-17 21:10:59 UTC) #1
nigeltao
LGTM. https://codereview.appspot.com/77080043/diff/1/cmd/ogleproxy/main.go File cmd/ogleproxy/main.go (right): https://codereview.appspot.com/77080043/diff/1/cmd/ogleproxy/main.go#newcode7 cmd/ogleproxy/main.go:7: Delete the blank line so that the comment ...
7 years, 8 months ago (2014-03-18 04:06:07 UTC) #2
r
https://codereview.appspot.com/77080043/diff/1/cmd/ogleproxy/main.go File cmd/ogleproxy/main.go (right): https://codereview.appspot.com/77080043/diff/1/cmd/ogleproxy/main.go#newcode7 cmd/ogleproxy/main.go:7: On 2014/03/18 04:06:07, nigeltao wrote: > Delete the blank ...
7 years, 8 months ago (2014-03-18 12:17:22 UTC) #3
r
7 years, 8 months ago (2014-03-18 12:18:05 UTC) #4
*** Submitted as https://code.google.com/p/ogle/source/detail?r=d44ba9529c0f ***

ogle: framework for communicating with proxy
Interface definition for interacting with program:
        program/program.go
Beginnings of RPC server to provide access to program:
        program/server/server.go
Beginnings of client to talk to RPC server, plus SSH connection:
        program/client/client.go
Beginnings of ogleproxy, which implements the RPC service:
        cmd/ogleproxy/main.go
Transport definitions for RPC:
        program/proxyrpc/proxyrpc.go

No tests yet - they will come when there's a little more in place.
But it works, as tested by an external toy.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/77080043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b