Issue 7707044: code review 7707044: cmd/dist: make cc rule match what cmd/go uses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7707044: code review 7707044: cmd/dist: make cc rule match what cmd/go uses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/dist: make cc rule match what cmd/go uses We added -I$GOROOT/pkg/$GOOS_$GOARCH in cmd/go (I think for use by cgo and swig, primarily) but didn't update cmd/dist. I was testing some other code and found that my changes built with cmd/go but failed during the initial bootstrap. Make them match again.

Patch Set 1 #

Patch Set 2 : diff -r c890576b82a1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c890576b82a1 https://code.google.com/p/go/ #

Patch Set 4 : diff -r cb4f87f228c8 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/cmd/dist/build.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-03-11 20:34:40 UTC) #1

rsc

12 years, 2 months ago (2013-03-11 20:50:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2c7e2d4bb47e ***

cmd/dist: make cc rule match what cmd/go uses

We added -I$GOROOT/pkg/$GOOS_$GOARCH in cmd/go
(I think for use by cgo and swig, primarily) but didn't
update cmd/dist. I was testing some other code and
found that my changes built with cmd/go but failed
during the initial bootstrap. Make them match again.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7707044

Expand All Messages | Collapse All Messages