code review 7703044: net: allow concurrent UNIX socket tests if TMPDIR is unique.

net: allow concurrent UNIX socket tests if TMPDIR is unique.

Only clever enough to allow concurrent stress testing.

[albert.strasheim, 2013-03-11 17:09:41]

Hello mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-03-11 17:11:38]

not lgtm

Sorry, but the reason we're hard-coding /tmp here is that the real $TMPDIR
may not allow Unix sockets to be created. It is fine if you want to put a
pid or something in the file name, but changing the directory doesn't work.

[albert.strasheim, 2013-03-11 17:20:54]

PTAL

Attempted a comment to help the next guy.

On 2013/03/11 17:11:38, rsc wrote:
> not lgtm
> 
> Sorry, but the reason we're hard-coding /tmp here is that the real $TMPDIR
> may not allow Unix sockets to be created. It is fine if you want to put a
> pid or something in the file name, but changing the directory doesn't work.

[rsc, 2013-03-11 17:24:18]

LGTM

[rsc, 2013-03-11 17:24:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=7c763891c5df ***

net: allow concurrent UNIX socket tests if TMPDIR is unique.

Only clever enough to allow concurrent stress testing.

R=mikioh.mikioh, rsc
CC=golang-dev
https://codereview.appspot.com/7703044

Committer: Russ Cox <rsc@golang.org>