Reduce code duplication due to FunctionDeclaration and FunctionExpression

Reduce code duplication due to FunctionDeclaration and FunctionExpression

BUG=None

Committed: https://code.google.com/p/traceur-compiler/source/detail?r=6040890

[peterhal, 2013-03-19 21:36:22]

LGTM

Thanks for taking care of this for me.

This looks great - I particularly like explicitly passing in the constructor as
a parameter rather than the tree.constructor method.

The one thing I'd add is a comment in trees.json detailing that there is code
which relies on FunctionExpression and FunctionDeclaration having the same
structure.

[arv, 2013-03-19 21:43:29]

Unfortunately comments are not allowed in JSON.
On Mar 19, 2013 5:36 PM, <peterhal@google.com> wrote:

> LGTM
>
> Thanks for taking care of this for me.
>
> This looks great - I particularly like explicitly passing in the
> constructor as a parameter rather than the tree.constructor method.
>
> The one thing I'd add is a comment in trees.json detailing that there is
> code which relies on FunctionExpression and FunctionDeclaration having
> the same structure.
>
>
https://codereview.appspot.**com/7693051/<https://codereview.appspot.com/7693...
>

[arv, 2013-03-19 22:42:40]

How about this? Is it too hacky?

[peterhal, 2013-03-19 23:04:01]

On 2013/03/19 22:42:40, arv-chromium wrote:
> How about this? Is it too hacky?

WTF! No comments in JSON!

Ugh. That's a heavy-weight solution, but yeah I think it'd be worth some
documentation.

[arv, 2013-03-20 19:22:47]

Committed patchset #3 manually as r6040890 (presubmit successful).