Issue 76890043: state: rename State.APIAddresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76890043: state: rename State.APIAddresses

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rog

Modified:
10 years, 1 month ago

Reviewers:
wwitzel3, dimitern, mp+211320

Visibility:
Public.

Description

state: rename State.APIAddresses To add an API addresses document, we will need to replace the current APIAddresses method with a method that reads the addresses from the document. However until we have a worker that populates the document, we still need access to the old functionality, which returns the API addresses by collating the addresses from the machines in state. This CL renames the old method so that we become free to implement the new method without breaking existing functionality. The old method will eventually be removed. Better suggestions for the name happily received (APIAddressesDeprecated?) https://code.launchpad.net/~rogpeppe/juju-core/516-state-set-api-addresses/+merge/211320 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: rename State.APIAddresses #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -13 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/address.go	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	state/api/deployer/deployer_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/provisioner/provisioner_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/uniter/state_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/common/addresses.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/common/addresses_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/deployer/deployer_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/provisioner/provisioner_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/state_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wwitzel3

On 2014/03/17 13:56:06, rog wrote: > Please take a look. LGTM

10 years, 1 month ago (2014-03-17 13:57:25 UTC) #2

dimitern

10 years, 1 month ago (2014-03-17 15:06:29 UTC) #4

LGTM, although you should do a follow-up to fix the API and include an
APIAddresses() method, otherwise in the time between this landing and the
follow-up we're breaking the API in a backward-incompatible manner.

Expand All Messages | Collapse All Messages