Issue 7688043: code review 7688043: cmd/ld: make mach-o sections match internal sections

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7688043: code review 7688043: cmd/ld: make mach-o sections match internal sections (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/ld: make mach-o sections match internal sections This brings Mach-O generation more in line with ELF generation. Having separate sections for the symtab and pclntab mean that we can find them that way, instead of using the deprecated debug segments. (And the host linker will keep separate sections for us, but probably not the debug segments.)

Patch Set 1 #

Patch Set 2 : diff -r 7778f3df0d19 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7778f3df0d19 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -155 lines)			Patch
M	src/cmd/ld/data.c	View	1	5 chunks	+10 lines, -5 lines	0 comments	Download
M	src/cmd/ld/dwarf.c	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/ld/macho.h	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/cmd/ld/macho.c	View	1	12 chunks	+62 lines, -83 lines	0 comments	Download
M	src/libmach/executable.c	View	1	4 chunks	+36 lines, -48 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-03-10 18:17:01 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=d008a181e8f5 *** cmd/ld: make mach-o sections match internal sections This brings Mach-O ...

12 years, 2 months ago (2013-03-10 18:17:08 UTC) #2

Message was sent while issue was closed.

lgtm

Expand All Messages | Collapse All Messages