Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(396)

Issue 76860047: Handle broken nrpe relations.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by benji
Modified:
8 years, 5 months ago
Reviewers:
mp+211781, frankban
Visibility:
Public.

Description

Handle broken nrpe relations. https://code.launchpad.net/~benji/charms/precise/juju-gui/bug-1284088/+merge/211781 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Handle broken nrpe relations. #

Patch Set 3 : Handle broken nrpe relations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/charmsupport/nrpe.py View 1 5 chunks +27 lines, -2 lines 0 comments Download
M scripts/update-nrpe.py View 1 1 chunk +21 lines, -7 lines 0 comments Download

Messages

Total messages: 4
benji
Please take a look.
8 years, 5 months ago (2014-03-19 17:09:57 UTC) #1
frankban
Thanks for this branch Benji: LGTM with minors. https://codereview.appspot.com/76860047/diff/1/scripts/charmsupport/nrpe.py File scripts/charmsupport/nrpe.py (right): https://codereview.appspot.com/76860047/diff/1/scripts/charmsupport/nrpe.py#newcode113 scripts/charmsupport/nrpe.py:113: def ...
8 years, 5 months ago (2014-03-19 17:42:03 UTC) #2
benji
Thanks for the good review. Read all the comments before replying because there is a ...
8 years, 5 months ago (2014-03-19 18:29:27 UTC) #3
benji
8 years, 5 months ago (2014-03-19 20:29:31 UTC) #4
*** Submitted:

Handle broken nrpe relations.

R=frankban
CC=
https://codereview.appspot.com/76860047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b