Issue 7684043: Make midiMaximumVolume take effect without initial dynamic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7684043: Make midiMaximumVolume take effect without initial dynamic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by pkx166h

Modified:
7 years, 1 month ago

Reviewers:

CC:
lilypond-devel_gnu.org, arrowyard

Visibility:
Public.

More Reviews

Description

Make midiMaximumVolume take effect without initial dynamic My idea is to ensure that the volume is *always* initialised in Dynamic_performer::process_music. The code to do that is mostly copied from what happens if there is an actual script event. The constant 0.71 was obtained by calculating backwards from the default velocity value (0x5a) in the Midi_note constructor, midi-item.cc line 179.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	lily/dynamic-performer.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

pkx166h

7 years, 1 month ago (2017-03-19 19:16:24 UTC) #1

author    Anders Pilegaard <arrowyard@gmail.com>   
Fri, 22 Feb 2013 08:32:18 +0000 (09:32 +0100)
committer    James Lowe <pkx166h@gmail.com>   
Sun, 17 Mar 2013 12:48:18 +0000 (12:48 +0000)
commit    [ra970166b725ea78a1b3866e0a0bd208155193222]

Expand All Messages | Collapse All Messages