Issue 76810044: code review 76810044: go.tools/go/types: avoid spurious "declared but not use...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76810044: code review 76810044: go.tools/go/types: avoid spurious "declared but not use... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by gri

Modified:
11 years, 5 months ago

Reviewers:
adonovan

CC:
golang-codereviews

Visibility:
Public.

Description

go.tools/go/types: avoid spurious "declared but not used" errors in case of other errors

Patch Set 2 : diff -r 26fe802525b9 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 26fe802525b9 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 4 : diff -r 26fe802525b9 https://code.google.com/p/go.tools #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -8 lines)			Patch
M	go/types/assignments.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	go/types/builtins.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	go/types/call.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	go/types/resolver.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	go/types/stmt.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	go/types/testdata/vardecl.src	View	1 2 3	2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 7 months ago (2014-03-20 18:24:46 UTC) #1

adonovan

LGTM thanks for the quick fix https://codereview.appspot.com/76810044/diff/40001/go/types/testdata/vardecl.src File go/types/testdata/vardecl.src (right): https://codereview.appspot.com/76810044/diff/40001/go/types/testdata/vardecl.src#newcode171 go/types/testdata/vardecl.src:171: delete blank

11 years, 7 months ago (2014-03-20 18:26:44 UTC) #2

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=85f66c5b2ea4&repo=tools *** go.tools/go/types: avoid spurious "declared but not used" errors in case ...

11 years, 7 months ago (2014-03-20 18:28:33 UTC) #3

Expand All Messages | Collapse All Messages