Issue 76780043: worker/uniter: explicit LookPath for hooks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76780043: worker/uniter: explicit LookPath for hooks

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by axw

Modified:
10 years, 1 month ago

Reviewers:
jameinel, mp+211247

Visibility:
Public.

Description

worker/uniter: explicit LookPath for hooks Go 1.3/tip changes os/exec.Command such that it conditionally calls LookPath, based on whether or not the specified path in is absolute. Since this differs across versions, I have simply changed our code to explicitly call LookPath all the time. No tests changed; an existing test failed with Go tip, and I verified the change fixes it. Fixes lp:1293310 https://code.launchpad.net/~axwalk/juju-core/lp1293310-non-existent-hooks/+merge/211247 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/uniter/context.go	View		2 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages