Issue 7675043: code review 7675043: misc/vim: test.sh seems to only work on Mac OS X.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7675043: code review 7675043: misc/vim: test.sh seems to only work on Mac OS X.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by wathiede

Modified:
12 years, 1 month ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

misc/vim: test.sh seems to only work on Mac OS X. cmp(1) on FreeBSD requires two file arguments. grep -P on Linux (at least Ubuntu 12.04) is described in the man page as "This is highly experimental" and doesn't seem to work. On FreeBSD the man page states "This option is not supported in FreeBSD." Needed this to work while debugging some funky behavior of 'Import' in my local vim setup.

Patch Set 1 #

Patch Set 2 : diff -r 1ae7ecffb332 https://code.google.com/p/go #

Patch Set 3 : diff -r 1ae7ecffb332 https://code.google.com/p/go #

Patch Set 4 : diff -r 1ae7ecffb332 https://code.google.com/p/go #

Patch Set 5 : diff -r 1ae7ecffb332 https://code.google.com/p/go #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	misc/vim/ftplugin/go/test.sh	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wathiede

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-03-10 00:03:38 UTC) #1

wathiede

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 1 month ago (2013-05-14 16:36:11 UTC) #2

dsymonds

LGTM The -P is meant to turn on PCRE-mode. =~ is a bash-ism, but I ...

12 years, 1 month ago (2013-05-14 16:53:27 UTC) #3

dsymonds

12 years, 1 month ago (2013-05-14 16:54:19 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=8efe0c9d6a0d ***

misc/vim: test.sh seems to only work on Mac OS X.

cmp(1) on FreeBSD requires two file arguments.  grep -P on Linux (at least
Ubuntu 12.04) is described in the man page as "This is highly
experimental" and doesn't seem to work. On FreeBSD the man page states
"This option  is not supported in FreeBSD."  Needed this to work while
debugging some funky behavior of 'Import' in my local vim setup.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/7675043

Committer: David Symonds <dsymonds@golang.org>

Expand All Messages | Collapse All Messages