api: http issue 205: New Sleeper interface

api: http issue 205: New Sleeper interface

depends on:
https://codereview.appspot.com/7443045/

[peleyal, 2013-03-12 20:08:52]

https://codereview.appspot.com/7674047/diff/1/google-api-client-android/src/m...
File
google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java
(right):

https://codereview.appspot.com/7674047/diff/1/google-api-client-android/src/m...
google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java:205:
sleeper.sleep(backOffMillis);
Just to make sure, the use of sleeper here is temporary, because I'm going to
change the code to use IOExpcetionHandler.

So the code will look something similar to:

public final String getToken() throws IOException, GoogleAuthException {
    while (true) {
      try {
        return GoogleAuthUtil.getToken(context, accountName, scope);
      } catch (IOException e) {
        // if IO exception handler handle the error, retry
        if (ioExceptionHandler != null || !ioExceptionHandler.handle()) {
          throw e;
        }
      }
    }
  }

[yanivi, 2013-03-12 21:19:54]

Yes, that's most likely the case, though review it as if it isn't
temporary, just in case we decide against IOExceptionHandler.

-- Yaniv

On Tuesday, March 12, 2013, wrote:

>
> https://codereview.appspot.**com/7674047/diff/1/google-api-**
> client-android/src/main/java/**com/google/api/client/**
>
googleapis/extensions/android/**gms/auth/**GoogleAccountCredential.java<https://codereview.appspot.com/7674047/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java>
> File
> google-api-client-android/src/**main/java/com/google/api/**
> client/googleapis/extensions/**android/gms/auth/**
> GoogleAccountCredential.java
> (right):
>
> https://codereview.appspot.**com/7674047/diff/1/google-api-**
> client-android/src/main/java/**com/google/api/client/**
> googleapis/extensions/android/**gms/auth/**GoogleAccountCredential.java#**
>
newcode205<https://codereview.appspot.com/7674047/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java#newcode205>
> google-api-client-android/src/**main/java/com/google/api/**
> client/googleapis/extensions/**android/gms/auth/**
> GoogleAccountCredential.java:**205:
> sleeper.sleep(backOffMillis);
> Just to make sure, the use of sleeper here is temporary, because I'm
> going to change the code to use IOExpcetionHandler.
>
> So the code will look something similar to:
>
> public final String getToken() throws IOException, GoogleAuthException {
>     while (true) {
>       try {
>         return GoogleAuthUtil.getToken(**context, accountName, scope);
>       } catch (IOException e) {
>         // if IO exception handler handle the error, retry
>         if (ioExceptionHandler != null || !ioExceptionHandler.handle())
> {
>           throw e;
>         }
>       }
>     }
>   }
>
>
https://codereview.appspot.**com/7674047/<https://codereview.appspot.com/7674...
>

[peleyal, 2013-03-13 13:08:43]

LGTM

[ngmiceli, 2013-03-13 14:37:23]

The class com.google.api.client.util.Sleeper does not exist. Is there another
changeset that this one is dependent on?

[peleyal, 2013-03-13 15:18:15]

On 2013/03/13 14:37:23, ngmiceli wrote:
> The class com.google.api.client.util.Sleeper does not exist. Is there another
> changeset that this one is dependent on?

Please add "based on https://codereview.appspot.com/7443045/" to the
description.