Issue 76730046: code review 76730046: cmd/gc: check exponent overflow and underflow in mparith

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 76730046: code review 76730046: cmd/gc: check exponent overflow and underflow in mparith (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by atom

Modified:
11 years ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

cmd/gc: check exponent overflow and underflow in mparith A too large float constant is an error. A too small float constant is rounded to zero. Fixes issue 7419 Update issue 6902

Patch Set 2 : diff -r cfbe0887d23b https://code.google.com/p/go/ #

Patch Set 3 : diff -r cfbe0887d23b https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r c26e48e32481 https://code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -8 lines)			Patch
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/mparith1.c	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/cmd/gc/mparith3.c	View	1	6 chunks	+29 lines, -5 lines	0 comments	Download
A	test/fixedbugs/issue7419.go	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

atom

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years ago (2014-03-17 09:24:02 UTC) #1

iant

https://codereview.appspot.com/76730046/diff/40001/src/cmd/gc/mparith1.c File src/cmd/gc/mparith1.c (right): https://codereview.appspot.com/76730046/diff/40001/src/cmd/gc/mparith1.c#newcode430 src/cmd/gc/mparith1.c:430: if((short)(dp-ex) != dp-ex) { I don't quite see why ...

11 years ago (2014-03-18 21:17:39 UTC) #2

atom

11 years ago (2014-03-18 21:28:59 UTC) #3

atom

11 years ago (2014-03-19 04:48:08 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=1ddce2d9ee32 ***

cmd/gc: check exponent overflow and underflow in mparith

A too large float constant is an error.
A too small float constant is rounded to zero.

Fixes issue 7419
Update issue 6902

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/76730046

Expand All Messages | Collapse All Messages